Chromium Code Reviews| Index: extensions/browser/app_window/app_window_geometry_cache_unittest.cc |
| diff --git a/extensions/browser/app_window/app_window_geometry_cache_unittest.cc b/extensions/browser/app_window/app_window_geometry_cache_unittest.cc |
| index 30f428dd08813d016e4699bb0b8c35e78cdb2ab7..05667e1aad7a5f92652171604c812c8a62b6f2ad 100644 |
| --- a/extensions/browser/app_window/app_window_geometry_cache_unittest.cc |
| +++ b/extensions/browser/app_window/app_window_geometry_cache_unittest.cc |
| @@ -121,7 +121,7 @@ void AppWindowGeometryCacheTest::AddGeometryAndLoadExtension( |
| const gfx::Rect& screen_bounds, |
| ui::WindowShowState state) { |
| std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue); |
| - base::DictionaryValue* value = new base::DictionaryValue; |
| + std::unique_ptr<base::DictionaryValue> value(new base::DictionaryValue); |
|
asargent_no_longer_on_chrome
2016/09/27 23:15:47
let's use base::MakeUnique for lines 123 and 124 h
|
| value->SetInteger("x", bounds.x()); |
| value->SetInteger("y", bounds.y()); |
| value->SetInteger("w", bounds.width()); |
| @@ -131,7 +131,7 @@ void AppWindowGeometryCacheTest::AddGeometryAndLoadExtension( |
| value->SetInteger("screen_bounds_w", screen_bounds.width()); |
| value->SetInteger("screen_bounds_h", screen_bounds.height()); |
| value->SetInteger("state", state); |
| - dict->SetWithoutPathExpansion(window_id, value); |
| + dict->SetWithoutPathExpansion(window_id, std::move(value)); |
| extension_prefs_->SetGeometryCache(extension_id, std::move(dict)); |
| LoadExtension(extension_id); |
| } |