Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/resources/geometry-interfaces-test-helpers.js

Issue 2370623003: [GeometryInterface] Clean-up layout tests for geometry interfaces. (Closed)
Patch Set: clean up. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-translate.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 function assert_identity_2d_matrix(actual, description) { 1 function assert_identity_2d_matrix(actual, description) {
2 assert_matrix_equals(actual, { 2 assert_matrix_equals(actual, {
3 m11: 1, m12: 0, m13: 0, m14: 0, 3 m11: 1, m12: 0, m13: 0, m14: 0,
4 m21: 0, m22: 1, m23: 0, m24: 0, 4 m21: 0, m22: 1, m23: 0, m24: 0,
5 m31: 0, m32: 0, m33: 1, m34: 0, 5 m31: 0, m32: 0, m33: 1, m34: 0,
6 m41: 0, m42: 0, m43: 0, m44: 1, 6 m41: 0, m42: 0, m43: 0, m44: 1,
7 is2D: true, isIdentity: true 7 is2D: true, isIdentity: true
8 }, description); 8 }, description);
9 } 9 }
10 10
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 is2D: false, isIdentity: false 52 is2D: false, isIdentity: false
53 }; 53 };
54 assert_matrix_equals(actual, full_expected, description); 54 assert_matrix_equals(actual, full_expected, description);
55 } else { 55 } else {
56 expected['is2D'] = false; 56 expected['is2D'] = false;
57 expected['isIdentity'] = false; 57 expected['isIdentity'] = false;
58 assert_matrix_equals(actual, expected, description); 58 assert_matrix_equals(actual, expected, description);
59 } 59 }
60 } 60 }
61 61
62 function assert_equals_do_not_care_native_zero(actual, expected, description) {
63
64 if (actual === -0) {
65 actual = 0;
66 }
67
68 if (expected === -0) {
69 expected = 0;
70 }
71
72 assert_equals(actual, expected, description);
73 }
74
62 function assert_matrix_equals(actual, expected, description) { 75 function assert_matrix_equals(actual, expected, description) {
zino 2016/09/27 16:31:18 Do we still need description?
63 assert_equals(actual.isIdentity, expected.isIdentity, description); 76 assert_equals(actual.isIdentity, expected.isIdentity, "isIdentity");
64 assert_equals(actual.is2D, expected.is2D, description); 77 assert_equals(actual.is2D, expected.is2D, "is2d");
65 assert_equals(actual.m11, expected.m11, description); 78 assert_equals_do_not_care_native_zero(actual.m11, expected.m11, "m11");
66 assert_equals(actual.m12, expected.m12, description); 79 assert_equals_do_not_care_native_zero(actual.m12, expected.m12, "m12");
67 assert_equals(actual.m13, expected.m13, description); 80 assert_equals_do_not_care_native_zero(actual.m13, expected.m13, "m13");
68 assert_equals(actual.m14, expected.m14, description); 81 assert_equals_do_not_care_native_zero(actual.m14, expected.m14, "m14");
69 assert_equals(actual.m21, expected.m21, description); 82 assert_equals_do_not_care_native_zero(actual.m21, expected.m21, "m21");
70 assert_equals(actual.m22, expected.m22, description); 83 assert_equals_do_not_care_native_zero(actual.m22, expected.m22, "m22");
71 assert_equals(actual.m23, expected.m23, description); 84 assert_equals_do_not_care_native_zero(actual.m23, expected.m23, "m23");
72 assert_equals(actual.m24, expected.m24, description); 85 assert_equals_do_not_care_native_zero(actual.m24, expected.m24, "m24");
73 assert_equals(actual.m31, expected.m31, description); 86 assert_equals_do_not_care_native_zero(actual.m31, expected.m31, "m31");
74 assert_equals(actual.m32, expected.m32, description); 87 assert_equals_do_not_care_native_zero(actual.m32, expected.m32, "m32");
75 assert_equals(actual.m33, expected.m33, description); 88 assert_equals_do_not_care_native_zero(actual.m33, expected.m33, "m33");
76 assert_equals(actual.m34, expected.m34, description); 89 assert_equals_do_not_care_native_zero(actual.m34, expected.m34, "m34");
77 assert_equals(actual.m41, expected.m41, description); 90 assert_equals_do_not_care_native_zero(actual.m41, expected.m41, "m41");
78 assert_equals(actual.m42, expected.m42, description); 91 assert_equals_do_not_care_native_zero(actual.m42, expected.m42, "m42");
79 assert_equals(actual.m43, expected.m43, description); 92 assert_equals_do_not_care_native_zero(actual.m43, expected.m43, "m43");
80 assert_equals(actual.m44, expected.m44, description); 93 assert_equals_do_not_care_native_zero(actual.m44, expected.m44, "m44");
81 assert_equals(actual.m11, actual.a, description); 94 assert_equals(actual.m11, actual.a, "a");
82 assert_equals(actual.m12, actual.b, description); 95 assert_equals(actual.m12, actual.b, "b");
83 assert_equals(actual.m21, actual.c, description); 96 assert_equals(actual.m21, actual.c, "c");
84 assert_equals(actual.m22, actual.d, description); 97 assert_equals(actual.m22, actual.d, "d");
85 assert_equals(actual.m41, actual.e, description); 98 assert_equals(actual.m41, actual.e, "e");
86 assert_equals(actual.m42, actual.f, description); 99 assert_equals(actual.m42, actual.f, "f");
87 } 100 }
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-translate.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698