Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1594)

Issue 23706007: Revert 221381 "[SystemInfo API] Implement DisplayInfoProvider::U..." (Closed)

Created:
7 years, 3 months ago by pneubeck (no reviews)
Modified:
7 years, 3 months ago
Reviewers:
hokein.wu
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 221381 "[SystemInfo API] Implement DisplayInfoProvider::U..." Broke compilation on Win Aura: http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20Aura%20Builder&number=11770 > [SystemInfo API] Implement DisplayInfoProvider::UpdateDisplayUnitInfoForPlatform method for Linux GTK. > > Also rename display_info_provider_x11 to display_info_provider_linux for > better understand. > > BUG=None > > Review URL: https://chromiumcodereview.appspot.com/22891026 TBR=Hokein.Wu@gmail.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221403

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -61 lines) Patch
D trunk/src/chrome/browser/extensions/api/system_display/display_info_provider_aura.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D trunk/src/chrome/browser/extensions/api/system_display/display_info_provider_gtk.cc View 1 chunk +0 lines, -35 lines 0 comments Download
A + trunk/src/chrome/browser/extensions/api/system_display/display_info_provider_x11.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/chrome/chrome_browser_extensions.gypi View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
pneubeck (no reviews)
7 years, 3 months ago (2013-09-05 13:17:45 UTC) #1
pneubeck (no reviews)
7 years, 3 months ago (2013-09-05 13:18:42 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r221403.

Powered by Google App Engine
This is Rietveld 408576698