Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 23706002: Merged r16393, r16396 into trunk branch. (Closed)

Created:
7 years, 3 months ago by Hannes Payer (out of office)
Modified:
7 years, 3 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Merged r16393, r16396 into trunk branch. Insert allocation memento clear instructions after the dominating allocate instruction. Merge verbatim descriptors from other (the descriptor of the map being updated) rather than this (descriptors of the most updated map found in the transition tree). BUG=v8:2863 R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16400

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -34 lines) Patch
M src/hydrogen-instructions.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-merge-descriptors.js View 1 chunk +60 lines, -30 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Hannes Payer (out of office)
7 years, 3 months ago (2013-08-28 13:36:38 UTC) #1
Toon Verwaest
(rubberstamp) lgtm
7 years, 3 months ago (2013-08-28 13:38:06 UTC) #2
Hannes Payer (out of office)
7 years, 3 months ago (2013-08-28 13:39:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16400 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698