Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 2370583002: unbreak builds with webrtc disabled (Closed)

Created:
4 years, 3 months ago by Mostyn Bramley-Moore
Modified:
4 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

unbreak builds with webrtc disabled https://codereview.chromium.org/2123863004 broke non-webrtc non-android builds. Let's fix that. BUG=487935 Committed: https://crrev.com/a2f67c812a83157e7eb24b81fd3aa51e978fbfb8 Cr-Commit-Position: refs/heads/master@{#420832}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/renderer_host/media/video_capture_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Mostyn Bramley-Moore
@tommi, braveyao: please take a look at this fixup for non-android non-webrtc builds after https://codereview.chromium.org/2123863004 ...
4 years, 3 months ago (2016-09-24 00:42:26 UTC) #4
tommi (sloooow) - chröme
lgtm
4 years, 3 months ago (2016-09-24 06:49:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370583002/1
4 years, 3 months ago (2016-09-24 06:49:11 UTC) #9
tommi (sloooow) - chröme
On 2016/09/24 06:49:01, tommi (chrömium) wrote: > lgtm and thanks for fixing!
4 years, 3 months ago (2016-09-24 06:49:18 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-24 06:54:11 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-24 06:55:47 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2f67c812a83157e7eb24b81fd3aa51e978fbfb8
Cr-Commit-Position: refs/heads/master@{#420832}

Powered by Google App Engine
This is Rietveld 408576698