Issue 237053002: Clean up default-platform gyp defines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 237053002: Clean up default-platform gyp defines (Closed)

Created:
6 years, 8 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 8 months ago

Reviewers:
dcarney

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Clean up default-platform gyp defines The files that are excluded do not exist at that location, so the rule is not effective. We'll first want to move the platform stuff into a separate library, so I'm just removing those lines for now BUG=v8:3015 R=dcarney@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=20727

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	tools/gyp/v8.gyp	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

6 years, 8 months ago (2014-04-14 13:38:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20727 (presubmit successful).

Expand Messages | Collapse Messages