Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: content/browser/devtools/protocol/browser_handler.cc

Issue 2370483002: DevTools: discover default port node servers for debugging (behind experiment) (Closed)
Patch Set: for landing Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/browser_handler.cc
diff --git a/content/browser/devtools/protocol/browser_handler.cc b/content/browser/devtools/protocol/browser_handler.cc
index 286ce15dabae57b55f384cec5a72f809cddd0093..aabbf40c43126a6ddce4210659bfabe497548df7 100644
--- a/content/browser/devtools/protocol/browser_handler.cc
+++ b/content/browser/devtools/protocol/browser_handler.cc
@@ -27,6 +27,12 @@ void BrowserHandler::SetClient(std::unique_ptr<Client> client) {
client_.swap(client);
}
+void BrowserHandler::Detached() {
+ for (const auto& host : attached_hosts_)
+ host->DetachClient(this);
+ attached_hosts_.clear();
+}
+
Response BrowserHandler::CreateBrowserContext(std::string* out_context_id) {
// For layering reasons this needs to be handled by
// DevToolsManagerDelegate::HandleCommand.
@@ -139,6 +145,11 @@ Response BrowserHandler::SendMessage(const std::string& target_id,
return Response::OK();
}
+Response BrowserHandler::SetRemoteLocations(
+ const std::vector<std::unique_ptr<base::DictionaryValue>>& locations) {
+ return Response::OK();
+}
+
void BrowserHandler::DispatchProtocolMessage(
DevToolsAgentHost* agent_host, const std::string& message) {
client_->DispatchMessage(DispatchMessageParams::Create()->

Powered by Google App Engine
This is Rietveld 408576698