Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: chrome/browser/devtools/chrome_devtools_manager_delegate.h

Issue 2370483002: DevTools: discover default port node servers for debugging (behind experiment) (Closed)
Patch Set: for landing Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/chrome_devtools_manager_delegate.h
diff --git a/chrome/browser/devtools/chrome_devtools_manager_delegate.h b/chrome/browser/devtools/chrome_devtools_manager_delegate.h
index 85aefa4f79c4bf00949e5e0f5be2f1f220d9d18a..567fcb5ee323a81e3cff9d3d0b04b2911d4a861a 100644
--- a/chrome/browser/devtools/chrome_devtools_manager_delegate.h
+++ b/chrome/browser/devtools/chrome_devtools_manager_delegate.h
@@ -6,14 +6,13 @@
#define CHROME_BROWSER_DEVTOOLS_CHROME_DEVTOOLS_MANAGER_DELEGATE_H_
#include <memory>
+#include <set>
#include "base/compiler_specific.h"
#include "base/macros.h"
+#include "chrome/browser/devtools/device/devtools_android_bridge.h"
#include "content/public/browser/devtools_manager_delegate.h"
-
-namespace content {
-class BrowserContext;
-}
+#include "net/base/host_port_pair.h"
class DevToolsNetworkProtocolHandler;
@@ -30,6 +29,8 @@ class ChromeDevToolsManagerDelegate : public content::DevToolsManagerDelegate {
void Inspect(content::DevToolsAgentHost* agent_host) override;
void DevToolsAgentStateChanged(content::DevToolsAgentHost* agent_host,
bool attached) override;
+ bool DiscoverTargets(
+ const content::DevToolsAgentHost::DiscoveryCallback& callback) override;
base::DictionaryValue* HandleCommand(
content::DevToolsAgentHost* agent_host,
base::DictionaryValue* command_dict) override;
@@ -41,7 +42,18 @@ class ChromeDevToolsManagerDelegate : public content::DevToolsManagerDelegate {
std::string GetFrontendResource(const std::string& path) override;
private:
+ void DevicesAvailable(
+ const content::DevToolsAgentHost::DiscoveryCallback& callback,
+ const DevToolsAndroidBridge::CompleteDevices& devices);
+
+ std::unique_ptr<base::DictionaryValue> SetRemoteLocations(
+ content::DevToolsAgentHost* agent_host,
+ int command_id,
+ base::DictionaryValue* params);
+
std::unique_ptr<DevToolsNetworkProtocolHandler> network_protocol_handler_;
+ std::unique_ptr<AndroidDeviceManager> device_manager_;
+ std::set<net::HostPortPair> tcp_locations_;
DISALLOW_COPY_AND_ASSIGN(ChromeDevToolsManagerDelegate);
};

Powered by Google App Engine
This is Rietveld 408576698