Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2370463002: [backport] Address integer overflow in sqlite3MulInt64. (Closed)

Created:
4 years, 3 months ago by Scott Hess - ex-Googler
Modified:
4 years, 2 months ago
Reviewers:
mmoroz
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[backport] Address integer overflow in sqlite3MulInt64. SQLite check-in http://www.sqlite.org/src/info/db3ebd7c52cfc5fc "Improved implementation of 64-bit signed integer multiply that correctly detects overflow (and promotes to floating-point) in some corner cases. Fix for ticket [1ec41379c9c1e400]" http://www.sqlite.org/src/info/1ec41379c9c1e400" BUG=601727 Committed: https://crrev.com/1459ddc66690416d9538693972ceb82c4772fc01 Cr-Commit-Position: refs/heads/master@{#421522}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -54 lines) Patch
M third_party/sqlite/amalgamation/sqlite3.c View 1 chunk +13 lines, -28 lines 0 comments Download
A third_party/sqlite/patches/0014-backport-Address-integer-overflow-in-sqlite3MulInt64.patch View 1 chunk +112 lines, -0 lines 0 comments Download
M third_party/sqlite/src/src/util.c View 1 chunk +11 lines, -26 lines 0 comments Download
M third_party/sqlite/src/test/expr.test View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Scott Hess - ex-Googler
4 years, 3 months ago (2016-09-23 17:35:49 UTC) #4
mmoroz
LGTM sorry for slow response (OOO) and thanks for porting the fix!
4 years, 2 months ago (2016-09-28 10:45:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370463002/1
4 years, 2 months ago (2016-09-28 14:34:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 15:22:55 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 15:24:27 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1459ddc66690416d9538693972ceb82c4772fc01
Cr-Commit-Position: refs/heads/master@{#421522}

Powered by Google App Engine
This is Rietveld 408576698