Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4185)

Unified Diff: cc/resources/video_resource_updater.cc

Issue 2370453003: 12-bit vp9 video support (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/resources/video_resource_updater.cc
diff --git a/cc/resources/video_resource_updater.cc b/cc/resources/video_resource_updater.cc
index 2584e0b3a83308af23ac83893c244a9badc04111..1831c5e810ef26eabf82ef4ab6ef6d0d52f50afb 100644
--- a/cc/resources/video_resource_updater.cc
+++ b/cc/resources/video_resource_updater.cc
@@ -84,6 +84,9 @@ VideoFrameExternalResources::ResourceType ResourceTypeForVideoFrame(
case media::PIXEL_FORMAT_YUV420P10:
case media::PIXEL_FORMAT_YUV422P10:
case media::PIXEL_FORMAT_YUV444P10:
+ case media::PIXEL_FORMAT_YUV420P12:
+ case media::PIXEL_FORMAT_YUV422P12:
+ case media::PIXEL_FORMAT_YUV444P12:
case media::PIXEL_FORMAT_UNKNOWN:
break;
}
@@ -289,6 +292,26 @@ static gfx::Size SoftwarePlaneDimension(media::VideoFrame* input_frame,
return gfx::Size(plane_width, plane_height);
}
+namespace {
+
+// Values are expected to be in [0.0..1.0]
+void MakeHalfFloat(uint16_t* dst, const uint16_t* src, float mult, size_t num) {
+ // TODO(hubbe): Make AVX and neon versions of this code.
+ for (size_t i = 0; i < num; i++) {
+ if (src[i] == 0) {
+ dst[i] = 0;
+ } else {
+ float value = src[i] * mult;
+ uint32_t f = *(uint32_t*)&value;
+ dst[i] = ((f >> 16) & 0x8000) |
+ ((((f & 0x7f800000) - 0x38000000) >> 13) & 0x7c00) |
+ ((f >> 13) & 0x03ff);
+ }
+ }
+}
+
+} // namespace
+
VideoFrameExternalResources VideoResourceUpdater::CreateForSoftwarePlanes(
scoped_refptr<media::VideoFrame> video_frame) {
TRACE_EVENT0("cc", "VideoResourceUpdater::CreateForSoftwarePlanes");
@@ -327,6 +350,11 @@ VideoFrameExternalResources VideoResourceUpdater::CreateForSoftwarePlanes(
case media::PIXEL_FORMAT_YUV444P10:
bits_per_channel = 10;
break;
+ case media::PIXEL_FORMAT_YUV420P12:
+ case media::PIXEL_FORMAT_YUV422P12:
+ case media::PIXEL_FORMAT_YUV444P12:
+ bits_per_channel = 12;
+ break;
}
// Only YUV software video frames are supported.
@@ -484,7 +512,6 @@ VideoFrameExternalResources VideoResourceUpdater::CreateForSoftwarePlanes(
needs_conversion = true;
// Note that the current method of converting integers to half-floats
// stops working if you have more than 10 bits of data.
- DCHECK_LE(bits_per_channel, 10);
} else if (bits_per_channel > 8) {
// If bits_per_channel > 8 and we can't use LUMINANCE_F16, we need to
// shift the data down and create an 8-bit texture.
@@ -508,13 +535,18 @@ VideoFrameExternalResources VideoResourceUpdater::CreateForSoftwarePlanes(
&upload_pixels_[upload_image_stride * row]);
const uint16_t* src = reinterpret_cast<uint16_t*>(
video_frame->data(i) + (video_stride_bytes * row));
- // Micro-benchmarking indicates that the compiler does
- // a good enough job of optimizing this loop that trying
- // to manually operate on one uint64 at a time is not
- // actually helpful.
- // Note to future optimizers: Benchmark your optimizations!
- for (size_t i = 0; i < bytes_per_row / 2; i++)
- dst[i] = src[i] | 0x3800;
+ if (bits_per_channel <= 10) {
+ // Micro-benchmarking indicates that the compiler does
+ // a good enough job of optimizing this loop that trying
+ // to manually operate on one uint64 at a time is not
+ // actually helpful.
+ // Note to future optimizers: Benchmark your optimizations!
+ for (size_t i = 0; i < bytes_per_row / 2; i++)
+ dst[i] = src[i] | 0x3800;
+ } else {
+ MakeHalfFloat(dst, src, 1.0f / ((1 << bits_per_channel) - 1),
+ bytes_per_row / 2);
+ }
} else if (shift != 0) {
// We have more-than-8-bit input which we need to shift
// down to fit it into an 8-bit texture.
@@ -540,7 +572,8 @@ VideoFrameExternalResources VideoResourceUpdater::CreateForSoftwarePlanes(
plane_resource.SetUniqueId(video_frame->unique_id(), i);
}
- if (plane_resource.resource_format() == LUMINANCE_F16) {
+ if (plane_resource.resource_format() == LUMINANCE_F16 &&
+ bits_per_channel <= 10) {
// By OR-ing with 0x3800, 10-bit numbers become half-floats in the
// range [0.5..1) and 9-bit numbers get the range [0.5..0.75).
//
« no previous file with comments | « no previous file | content/browser/media/media_browsertest.cc » ('j') | media/renderers/skcanvas_video_renderer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698