12-bit vp9 video support

media/renderers/skcanvas_video_renderer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/renderers/skcanvas_video_renderer.h"
 
 #include <limits>
 
 #include "base/macros.h"
 #include "gpu/GLES2/gl2extchromium.h"
@@ skipping 433 matching lines @@
 
 namespace {
 
 // libyuv doesn't support 9- and 10-bit video frames yet. This function
 // creates a regular 8-bit video frame which we can give to libyuv.
 scoped_refptr<VideoFrame> DownShiftHighbitVideoFrame(
     const VideoFrame* video_frame) {
   VideoPixelFormat format;
   int shift = 1;
   switch (video_frame->format()) {
+    case PIXEL_FORMAT_YUV420P12:
+      shift += 2;
     case PIXEL_FORMAT_YUV420P10:
-      shift = 2;
+      shift++;

[DaleCurtis, 2016/09/23 23:42:24]

Why the change?

[hubbe, 2016/09/23 23:43:06]

Because of fall-through?

[DaleCurtis, 2016/09/23 23:45:42]

Oooh, yuck. This seems like it would be way more legible w/ a break and exact
assignment instead of fall-through + accumulation?

[hubbe, 2016/09/23 23:49:49]

It's longer and seems a bit more error-prone to me, but ok.

     case PIXEL_FORMAT_YUV420P9:
       format = PIXEL_FORMAT_I420;
       break;
+
+    case PIXEL_FORMAT_YUV422P12:
+      shift += 2;
     case PIXEL_FORMAT_YUV422P10:
-      shift = 2;
+      shift++;
     case PIXEL_FORMAT_YUV422P9:
       format = PIXEL_FORMAT_YV16;
       break;
+
+    case PIXEL_FORMAT_YUV444P12:
+      shift += 2;
     case PIXEL_FORMAT_YUV444P10:
-      shift = 2;
+      shift++;
     case PIXEL_FORMAT_YUV444P9:
       format = PIXEL_FORMAT_YV24;
       break;
 
     default:
       NOTREACHED();
       return nullptr;
   }
   scoped_refptr<VideoFrame> ret = VideoFrame::CreateFrame(
       format, video_frame->coded_size(), video_frame->visible_rect(),
@@ skipping 109 matching lines @@
                           static_cast<uint8_t*>(rgb_pixels), row_bytes,
                           video_frame->visible_rect().width(),
                           video_frame->visible_rect().height());
       break;
 
     case PIXEL_FORMAT_YUV420P9:
     case PIXEL_FORMAT_YUV422P9:
     case PIXEL_FORMAT_YUV444P9:
     case PIXEL_FORMAT_YUV420P10:
     case PIXEL_FORMAT_YUV422P10:
-    case PIXEL_FORMAT_YUV444P10: {
+    case PIXEL_FORMAT_YUV444P10:
+    case PIXEL_FORMAT_YUV420P12:
+    case PIXEL_FORMAT_YUV422P12:
+    case PIXEL_FORMAT_YUV444P12: {
       scoped_refptr<VideoFrame> temporary_frame =
           DownShiftHighbitVideoFrame(video_frame);
       ConvertVideoFrameToRGBPixels(temporary_frame.get(), rgb_pixels,
                                    row_bytes);
       break;
     }
 
     case PIXEL_FORMAT_NV12:
     case PIXEL_FORMAT_NV21:
     case PIXEL_FORMAT_UYVY:
@@ skipping 148 matching lines @@
     if (!last_image_)  // Couldn't create the SkImage.
       return false;
     last_timestamp_ = video_frame->timestamp();
   }
   last_image_deleting_timer_.Reset();
   DCHECK(!!last_image_);
   return true;
 }
 
 }  // namespace media