Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1906)

Issue 2370403003: [SPv2] Set an overflowClip clip node if an element has contain: paint. (Closed)

Created:
4 years, 2 months ago by chrishtr
Modified:
4 years, 2 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[SPv2] Set an overflowClip clip node if an element has contain: paint. BUG=593596 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/10f853ca30c391d679d7989dfc7b54d9ac78e177 Cr-Commit-Position: refs/heads/master@{#421432}

Patch Set 1 #

Patch Set 2 : none #

Patch Set 3 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp View 1 2 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
chrishtr
4 years, 2 months ago (2016-09-27 23:56:28 UTC) #5
pdr.
On 2016/09/27 at 23:56:28, chrishtr wrote: > LGTM
4 years, 2 months ago (2016-09-28 00:07:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370403003/20001
4 years, 2 months ago (2016-09-28 00:42:23 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/303949)
4 years, 2 months ago (2016-09-28 01:13:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370403003/40001
4 years, 2 months ago (2016-09-28 01:56:48 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-28 03:07:56 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 03:09:38 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/10f853ca30c391d679d7989dfc7b54d9ac78e177
Cr-Commit-Position: refs/heads/master@{#421432}

Powered by Google App Engine
This is Rietveld 408576698