Source/modules/filesystem/DirectoryReaderSync.cpp - Issue 23704004: Make WebFileSystemCallbacks not self-destruct, deprecate AsyncFileSystem

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/filesystem/DirectoryReaderSync.cpp

Issue 23704004: Make WebFileSystemCallbacks not self-destruct, deprecate AsyncFileSystem (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/filesystem/DirectoryReaderSync.cpp

diff --git a/Source/modules/filesystem/DirectoryReaderSync.cpp b/Source/modules/filesystem/DirectoryReaderSync.cpp

index df36ccf0579d19355ae2795f9628826c5e55cb55..82d5298aebe85a9b47adb64335b663d4424b3faa 100644

--- a/Source/modules/filesystem/DirectoryReaderSync.cpp

+++ b/Source/modules/filesystem/DirectoryReaderSync.cpp

@@ -53,7 +53,7 @@ EntrySyncVector DirectoryReaderSync::readEntries(ExceptionState& es)

if (!m_hasMoreEntries)

return EntrySyncVector();

- EntriesSyncCallbackHelper helper(m_fileSystem->asyncFileSystem());

+ EntriesSyncCallbackHelper helper;

if (!m_fileSystem->readDirectory(this, m_fullPath, helper.successCallback(), helper.errorCallback(), DOMFileSystemBase::Synchronous)) {

es.throwDOMException(InvalidModificationError, ExceptionMessages::failedToExecute("readEntries", "DirectoryReaderSync"));

setHasMoreEntries(false);