Make WebFileSystemCallbacks not self-destruct, deprecate AsyncFileSystem

Source/modules/filesystem/SyncCallbackHelper.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2013 Samsung Electronics. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 59 matching lines @@
         EntrySyncVector result;
         size_t entryCount = entries.size();
         result.reserveInitialCapacity(entryCount);
         for (size_t i = 0; i < entryCount; ++i)
             result.uncheckedAppend(EntrySync::create(entries[i].get()));
         return result;
     }
 };
 
 // A helper template for FileSystemSync implementation.
-template <typename SuccessCallback, typename ObserverType, typename CallbackArg, typename ResultType>
+template <typename SuccessCallback, typename CallbackArg, typename ResultType>
 class SyncCallbackHelper {
     WTF_MAKE_NONCOPYABLE(SyncCallbackHelper);
 public:
-    typedef SyncCallbackHelper<SuccessCallback, ObserverType, CallbackArg, ResultType> HelperType;
+    typedef SyncCallbackHelper<SuccessCallback, CallbackArg, ResultType> HelperType;
     typedef HelperResultType<ResultType, CallbackArg> ResultTypeTrait;
     typedef typename ResultTypeTrait::StorageType ResultStorageType;
     typedef typename ResultTypeTrait::ReturnType ResultReturnType;
 
-    SyncCallbackHelper(ObserverType* observer = 0)
-        : m_observer(observer)
-        , m_successCallback(SuccessCallbackImpl::create(this))
+    SyncCallbackHelper()
+        : m_successCallback(SuccessCallbackImpl::create(this))
         , m_errorCallback(ErrorCallbackImpl::create(this))
         , m_errorCode(FileError::OK)
         , m_completed(false)
     {
     }
 
     ResultReturnType getResult(ExceptionState& es)
     {
-        if (m_observer) {
-            while (!m_completed) {
-                if (!m_observer->waitForOperationToComplete()) {
-                    m_errorCode = FileError::ABORT_ERR;
-                    break;
-                }
-            }
-        }
         if (m_errorCode)
             FileError::throwDOMException(es, m_errorCode);
 
         return m_result;
     }
 
     PassRefPtr<SuccessCallback> successCallback() { return m_successCallback; }
     PassRefPtr<ErrorCallback> errorCallback() { return m_errorCallback; }
 
 private:
@@ skipping 54 matching lines @@
         m_errorCode = code;
         m_completed = true;
     }
 
     void setResult(CallbackArg result)
     {
         m_result = ResultTypeTrait::createFromCallbackArg(result);
         m_completed = true;
     }
 
-    ObserverType* m_observer;
     RefPtr<SuccessCallbackImpl> m_successCallback;
     RefPtr<ErrorCallbackImpl> m_errorCallback;
     ResultStorageType m_result;
     FileError::ErrorCode m_errorCode;
     bool m_completed;
 };
 
 struct EmptyType : public RefCounted<EmptyType> {
     static PassRefPtr<EmptyType> create(EmptyType*)
     {
         return 0;
     }
 };
 
-struct EmptyObserverType {
-    bool waitForOperationToComplete()
-    {
-        return false;
-    }
-};
-
-typedef SyncCallbackHelper<EntryCallback, AsyncFileSystem, Entry*, EntrySync> EntrySyncCallbackHelper;
-typedef SyncCallbackHelper<EntriesCallback, AsyncFileSystem, const EntryVector&, EntrySyncVector> EntriesSyncCallbackHelper;
-typedef SyncCallbackHelper<MetadataCallback, AsyncFileSystem, Metadata*, Metadata> MetadataSyncCallbackHelper;
-typedef SyncCallbackHelper<VoidCallback, AsyncFileSystem, EmptyType*, EmptyType> VoidSyncCallbackHelper;
-typedef SyncCallbackHelper<FileSystemCallback, EmptyObserverType, DOMFileSystem*, DOMFileSystemSync> FileSystemSyncCallbackHelper;
+typedef SyncCallbackHelper<EntryCallback, Entry*, EntrySync> EntrySyncCallbackHelper;
+typedef SyncCallbackHelper<EntriesCallback, const EntryVector&, EntrySyncVector> EntriesSyncCallbackHelper;
+typedef SyncCallbackHelper<MetadataCallback, Metadata*, Metadata> MetadataSyncCallbackHelper;
+typedef SyncCallbackHelper<VoidCallback, EmptyType*, EmptyType> VoidSyncCallbackHelper;
+typedef SyncCallbackHelper<FileSystemCallback, DOMFileSystem*, DOMFileSystemSync> FileSystemSyncCallbackHelper;
 
 } // namespace WebCore
 
 #endif // SyncCallbackHelper_h