Extracting placeholder information from Webkit to Blimp

content/browser/renderer_host/render_widget_host_view_base.h

Index: content/browser/renderer_host/render_widget_host_view_base.h
diff --git a/content/browser/renderer_host/render_widget_host_view_base.h b/content/browser/renderer_host/render_widget_host_view_base.h
index ce60e771273c9431ac86f9af584a7366e53c6b00..ef4db9eed7a34a2c2749e7ffcc5d9bf821274147 100644
--- a/content/browser/renderer_host/render_widget_host_view_base.h
+++ b/content/browser/renderer_host/render_widget_host_view_base.h
@@ -94,6 +94,9 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
   void SetBackgroundColorToDefault() final;
   bool GetBackgroundOpaque() override;
   ui::TextInputClient* GetTextInputClient() override;
+  void FetchTextInputInfo(
+      base::Callback<void(const std::string&, const std::string&)>& reply)
+      override;
   void WasUnOccluded() override {}
   void WasOccluded() override {}
   bool IsShowingContextMenu() const override;
@@ -313,6 +316,11 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
       const gfx::Range& range,
       const std::vector<gfx::Rect>& character_bounds);
 
+  // This method contains response for the FetchTextInputInfo request.
+  void OnTextInputInfoReply(int request_id,
+                            const std::string& text,
+                            const std::string& placeholder);
+
   //----------------------------------------------------------------------------
   // The following pure virtual methods are implemented by derived classes.
 
@@ -495,6 +503,13 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
 
   uint32_t renderer_frame_number_;
 
+  typedef std::map<int,

[David Trainor- moved to gerrit, 2016/10/26 01:36:42]

using?

[shaktisahu, 2016/10/31 23:13:58]

Done.

+                   base::Callback<void(const std::string&, const std::string&)>>

[David Trainor- moved to gerrit, 2016/10/26 01:36:42]

Pull out a callback with using?

[shaktisahu, 2016/10/31 23:13:59]

Done.

+      TextInputReplyMap;
+  TextInputReplyMap text_input_callbacks_;
+
+  int next_request_id_;

[David Trainor- moved to gerrit, 2016/10/26 01:36:42]

Should this just be in an anonymous namespace in the CC file?

[shaktisahu, 2016/10/31 23:13:59]

Done.

+
   base::OneShotTimer flush_input_timer_;
 
   base::ObserverList<RenderWidgetHostViewBaseObserver> observers_;