third_party/WebKit/Source/web/WebViewImpl.cpp - Issue 2370393002: Extracting placeholder information from Webkit to Blimp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2370393002: Extracting placeholder information from Webkit to Blimp (Closed)

Patch Set: Observing InputMethod Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebViewImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp

index f3691ab0d9df068f3dad7bc7368733ce2a5d264c..8d49e8147a41c4d1338d4cbc3dc8127005ca6190 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.cpp

+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp

@@ -2459,6 +2459,7 @@ WebTextInputInfo WebViewImpl::textInputInfo()

// Emits an object replacement character for each replaced element so that

// it is exposed to IME and thus could be deleted by IME on android.

info.value = plainText(EphemeralRange::rangeOfContents(*element), TextIteratorEmitsObjectReplacementCharacter);

+ info.placeholder = focusedElement()->fastGetAttribute(HTMLNames::placeholderAttr);

if (info.value.isEmpty())

return info;