Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2534)

Unified Diff: blimp/engine/session/tab.h

Issue 2370393002: Extracting placeholder information from Webkit to Blimp (Closed)
Patch Set: merge origin/master Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/engine/session/blimp_engine_session.cc ('k') | blimp/engine/session/tab.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/engine/session/tab.h
diff --git a/blimp/engine/session/tab.h b/blimp/engine/session/tab.h
index e6cb86c822caec02bcf63c846d39148f2fc78a5a..bec6ea906da92758478db2ef59eb72d8d8be8911 100644
--- a/blimp/engine/session/tab.h
+++ b/blimp/engine/session/tab.h
@@ -14,6 +14,7 @@
namespace content {
class RenderViewHost;
class WebContents;
+struct FormFieldData;
}
namespace blimp {
@@ -69,6 +70,10 @@ class Tab : public content::WebContentsObserver,
content::RenderWidgetHost* render_widget_host,
const std::vector<uint8_t>& message) override;
+ // Text input related methods.
+ void ShowTextInputUI();
+ void HideTextInputUI();
+
private:
// content::WebContentsObserver implementation.
void RenderViewCreated(content::RenderViewHost* render_view_host) override;
@@ -76,6 +81,10 @@ class Tab : public content::WebContentsObserver,
content::RenderViewHost* new_host) override;
void RenderViewDeleted(content::RenderViewHost* render_view_host) override;
+ // Sends text input field related information to the client.
+ void ProcessTextInputInfo(int request_id,
+ const content::FormFieldData& field_data);
+
std::unique_ptr<content::WebContents> web_contents_;
const int tab_id_;
EngineRenderWidgetFeature* render_widget_feature_;
@@ -84,6 +93,11 @@ class Tab : public content::WebContentsObserver,
// Tracks the page load status for a tab.
PageLoadTracker page_load_tracker_;
+ // Tracks the number of text input requests.
+ int current_form_request_id_;
+
+ base::WeakPtrFactory<Tab> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(Tab);
};
« no previous file with comments | « blimp/engine/session/blimp_engine_session.cc ('k') | blimp/engine/session/tab.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698