Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2370393002: Extracting placeholder information from Webkit to Blimp (Closed)
Patch Set: Removed callback from RenderFrameHost destructor Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 4bbb482a128f7e38a442e9e70b217e17c2595a4b..b20d337c7ca6266526bd5fa3554d3706e9f66a69 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -86,6 +86,7 @@
#include "content/public/common/content_switches.h"
#include "content/public/common/file_chooser_file_info.h"
#include "content/public/common/file_chooser_params.h"
+#include "content/public/common/form_field_data.h"
#include "content/public/common/isolated_world_ids.h"
#include "content/public/common/service_manager_connection.h"
#include "content/public/common/service_names.h"
@@ -388,6 +389,8 @@ RenderFrameHostImpl::~RenderFrameHostImpl() {
for (const auto& iter : visual_state_callbacks_)
iter.second.Run(false);
+ form_field_data_callbacks_.clear();
+
if (render_widget_host_ &&
render_widget_host_->owned_by_render_frame_host()) {
// Shutdown causes the RenderWidgetHost to delete itself.
@@ -694,6 +697,8 @@ bool RenderFrameHostImpl::OnMessageReceived(const IPC::Message &msg) {
IPC_MESSAGE_HANDLER(FrameHostMsg_DispatchLoad, OnDispatchLoad)
IPC_MESSAGE_HANDLER(FrameHostMsg_TextSurroundingSelectionResponse,
OnTextSurroundingSelectionResponse)
+ IPC_MESSAGE_HANDLER(FrameHostMsg_FocusedFormFieldDataResponse,
+ OnFocusedFormFieldDataResponse)
IPC_MESSAGE_HANDLER(AccessibilityHostMsg_Events, OnAccessibilityEvents)
IPC_MESSAGE_HANDLER(AccessibilityHostMsg_LocationChanges,
OnAccessibilityLocationChanges)
@@ -1475,7 +1480,11 @@ void RenderFrameHostImpl::OnRenderProcessGone(int status, int exit_code) {
// since we're never going to get a response from this renderer.
for (const auto& iter : ax_tree_snapshot_callbacks_)
iter.second.Run(ui::AXTreeUpdate());
+
ax_tree_snapshot_callbacks_.clear();
+ javascript_callbacks_.clear();
+ visual_state_callbacks_.clear();
+ form_field_data_callbacks_.clear();
// Ensure that future remote interface requests are associated with the new
// process's channel.
@@ -1663,6 +1672,24 @@ void RenderFrameHostImpl::OnTextSurroundingSelectionResponse(
text_surrounding_selection_callback_.Reset();
}
+void RenderFrameHostImpl::RequestFocusedFormFieldData(
+ FormFieldDataCallback& callback) {
+ static int next_id = 1;
+ int request_id = ++next_id;
+ form_field_data_callbacks_[request_id] = callback;
+ Send(new FrameMsg_FocusedFormFieldDataRequest(GetRoutingID(), request_id));
+}
+
+void RenderFrameHostImpl::OnFocusedFormFieldDataResponse(
+ int request_id,
+ const FormFieldData& field_data) {
+ auto it = form_field_data_callbacks_.find(request_id);
+ if (it != form_field_data_callbacks_.end()) {
+ it->second.Run(field_data);
+ form_field_data_callbacks_.erase(it);
+ }
+}
+
void RenderFrameHostImpl::OnDidAccessInitialDocument() {
delegate_->DidAccessInitialDocument();
}

Powered by Google App Engine
This is Rietveld 408576698