Extracting placeholder information from Webkit to Blimp

content/common/frame_messages.h

Index: content/common/frame_messages.h
diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h
index d9e9e30267411312464d9a760c0cbedf547fef83..972b4b1f117ab4980a99d96a11af924b2564b92f 100644
--- a/content/common/frame_messages.h
+++ b/content/common/frame_messages.h
@@ -31,6 +31,7 @@
 #include "content/public/common/context_menu_params.h"
 #include "content/public/common/file_chooser_file_info.h"
 #include "content/public/common/file_chooser_params.h"
+#include "content/public/common/form_field_data.h"
 #include "content/public/common/frame_navigate_params.h"
 #include "content/public/common/javascript_message_type.h"
 #include "content/public/common/page_importance_signals.h"
@@ -514,6 +515,12 @@ IPC_STRUCT_TRAITS_BEGIN(content::ContentSecurityPolicyHeader)
   IPC_STRUCT_TRAITS_MEMBER(source)
 IPC_STRUCT_TRAITS_END()
 
+IPC_STRUCT_TRAITS_BEGIN(content::FormFieldData)
+  IPC_STRUCT_TRAITS_MEMBER(text)
+  IPC_STRUCT_TRAITS_MEMBER(placeholder)
+  IPC_STRUCT_TRAITS_MEMBER(text_input_type)
+IPC_STRUCT_TRAITS_END()
+
 IPC_STRUCT_TRAITS_BEGIN(content::FileChooserFileInfo)
   IPC_STRUCT_TRAITS_MEMBER(file_path)
   IPC_STRUCT_TRAITS_MEMBER(display_name)
@@ -718,6 +725,10 @@ IPC_MESSAGE_ROUTED0(FrameMsg_DeleteProxy)
 IPC_MESSAGE_ROUTED1(FrameMsg_TextSurroundingSelectionRequest,
                     uint32_t /* max_length */)
 
+// Requests the renderer for information about currently focused text input

[Charlie Reis, 2016/11/11 22:20:46]

nit: Requests information about ... from the renderer.

[shaktisahu, 2016/11/15 05:44:54]

Done.

+// element.
+IPC_MESSAGE_ROUTED1(FrameMsg_FocusedFormFieldDataRequest, int)

[Charlie Reis, 2016/11/11 22:20:46]

Use a /* comment */ to indicate what the int is.

[shaktisahu, 2016/11/15 05:44:54]

Done.

+
 // Tells the renderer to insert a link to the specified stylesheet. This is
 // needed to support navigation transitions.
 IPC_MESSAGE_ROUTED1(FrameMsg_AddStyleSheetByURL, std::string)
@@ -1358,6 +1369,12 @@ IPC_MESSAGE_ROUTED3(FrameHostMsg_TextSurroundingSelectionResponse,
                     uint32_t, /* startOffset */
                     uint32_t/* endOffset */)
 
+// Response for FrameMsg_FocusedFormFieldDataRequest. Sends info about the
+// currently focused form field.
+IPC_MESSAGE_ROUTED2(FrameHostMsg_FocusedFormFieldDataResponse,
+                    int,

[Charlie Reis, 2016/11/11 22:20:46]

Add comments with parameter names, as above and below.

[shaktisahu, 2016/11/15 05:44:54]

Done.

+                    content::FormFieldData)
+
 // Register a new handler for URL requests with the given scheme.
 IPC_MESSAGE_ROUTED4(FrameHostMsg_RegisterProtocolHandler,
                     std::string /* scheme */,