Extracting placeholder information from Webkit to Blimp

content/browser/frame_host/render_frame_host_impl.h

Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index e6efd6a475eb71b13b686a26204c9480b1419190..71d44abf77cf6180a7f98f90c3e3ea0b2e295083 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -165,6 +165,7 @@ class CONTENT_EXPORT RenderFrameHostImpl
   void RequestTextSurroundingSelection(
       const TextSurroundingSelectionCallback& callback,
       int max_length) override;
+  void RequestFocusedFormFieldData(FormFieldDataCallback& callback) override;
 
   // mojom::FrameHost
   void GetInterfaceProvider(
@@ -505,6 +506,10 @@ class CONTENT_EXPORT RenderFrameHostImpl
 #endif
 #endif
 
+  // This method contains response for the focused field info request.
+  void OnFocusedFormFieldDataResponse(int request_id,

[Charlie Reis, 2016/11/11 22:20:46]

nit: This should be declared with the other IPC handlers.

[shaktisahu, 2016/11/15 05:44:54]

Done.

+                                      const FormFieldData& field_data);
+
   // PlzNavigate: Indicates that a navigation is ready to commit and can be
   // handled by this RenderFrame.
   void CommitNavigation(ResourceResponse* response,
@@ -875,6 +880,9 @@ class CONTENT_EXPORT RenderFrameHostImpl
   std::map<int, JavaScriptResultCallback> javascript_callbacks_;
   std::map<uint64_t, VisualStateCallback> visual_state_callbacks_;
 
+  // Callbacks for getting text input info.
+  std::map<int, FormFieldDataCallback> form_field_data_callbacks_;

[Charlie Reis, 2016/11/11 22:20:46]

As dtrainor@ noted, there's a risk that these will leak if we don't get a
response.  We should clear them in RFHI::OnRenderProcessGone, similar to
ax_tree_snapshot_callbacks_.  (I'm surprised we don't do that for the two
callback maps above-- feel free to add that as well, or I can do it in a
followup.)

[shaktisahu, 2016/11/15 05:44:54]

Done.

+
   // RenderFrameHosts that need management of the rendering and input events
   // for their frame subtrees require RenderWidgetHosts. This typically
   // means frames that are rendered in different processes from their parent