third_party/WebKit/Source/core/editing/InputMethodController.cpp - Issue 2370393002: Extracting placeholder information from Webkit to Blimp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodController.cpp

Issue 2370393002: Extracting placeholder information from Webkit to Blimp (Closed)

Patch Set: dtrainor comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/InputMethodController.cpp

diff --git a/third_party/WebKit/Source/core/editing/InputMethodController.cpp b/third_party/WebKit/Source/core/editing/InputMethodController.cpp

index 3681b8a9ffae6dd4813029d118f21824d72bd981..b3a7a3b177aac1a6203fad34b59a295962ac0e6c 100644

--- a/third_party/WebKit/Source/core/editing/InputMethodController.cpp

+++ b/third_party/WebKit/Source/core/editing/InputMethodController.cpp

@@ -967,6 +967,9 @@ WebTextInputInfo InputMethodController::textInputInfo() const {

info.value = plainText(EphemeralRange::rangeOfContents(*element),

TextIteratorEmitsObjectReplacementCharacter);

+ element = frame().document()->focusedElement();

+ info.placeholder = element->fastGetAttribute(HTMLNames::placeholderAttr);

if (info.value.isEmpty())

return info;