Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 2370393002: Extracting placeholder information from Webkit to Blimp (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_base.h
diff --git a/content/browser/renderer_host/render_widget_host_view_base.h b/content/browser/renderer_host/render_widget_host_view_base.h
index bd39916632fc28966b47d2cc643d776be6bdc07f..dbc2c4f3cbd1642a8fa50f45b3dfd50b277fa7fd 100644
--- a/content/browser/renderer_host/render_widget_host_view_base.h
+++ b/content/browser/renderer_host/render_widget_host_view_base.h
@@ -399,6 +399,18 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
virtual void LockCompositingSurface() = 0;
virtual void UnlockCompositingSurface() = 0;
+ // Returns a reference to the current instance of TextInputManager. The
+ // reference is obtained from RenderWidgetHostDelegate. The first time a non-
+ // null reference is obtained, its value is cached in |text_input_manager_|
+ // and this view is registered with it. The RWHV will unregister from the
+ // TextInputManager if it is destroyed or if the TextInputManager itself is
+ // destroyed. The unregistration of the RWHV from TextInputManager is
+ // necessary and must be done by explicitly calling
+ // TextInputManager::Unregister.
+ // It is safer to use this method rather than directly dereferencing
+ // |text_input_manager_|.
+ TextInputManager* GetTextInputManager();
EhsanK 2016/09/28 16:14:11 Why is this public now? I couldn't find the usage.
shaktisahu 2016/09/28 20:17:23 Oh. I will change it back to protected. I don't ne
+
// Add and remove observers for lifetime event notifications. The order in
// which notifications are sent to observers is undefined. Clients must be
// sure to remove the observer before they go away.
@@ -415,18 +427,6 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
void NotifyObserversAboutShutdown();
- // Returns a reference to the current instance of TextInputManager. The
- // reference is obtained from RenderWidgetHostDelegate. The first time a non-
- // null reference is obtained, its value is cached in |text_input_manager_|
- // and this view is registered with it. The RWHV will unregister from the
- // TextInputManager if it is destroyed or if the TextInputManager itself is
- // destroyed. The unregistration of the RWHV from TextInputManager is
- // necessary and must be done by explicitly calling
- // TextInputManager::Unregister.
- // It is safer to use this method rather than directly dereferencing
- // |text_input_manager_|.
- TextInputManager* GetTextInputManager();
-
// Whether this view is a popup and what kind of popup it is (select,
// autofill...).
blink::WebPopupType popup_type_;

Powered by Google App Engine
This is Rietveld 408576698