Extracting placeholder information from Webkit to Blimp

content/public/browser/web_contents_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_
 
 #include <stdint.h>
 
 #include <set>
 #include <string>
 
 #include "base/callback.h"
 #include "base/strings/string16.h"
 #include "build/build_config.h"
 #include "content/common/content_export.h"
 #include "content/public/browser/bluetooth_chooser.h"
 #include "content/public/browser/invalidate_type.h"
 #include "content/public/common/media_stream_request.h"
 #include "content/public/common/security_style.h"
 #include "content/public/common/window_container_type.h"
 #include "third_party/WebKit/public/platform/WebDisplayMode.h"
 #include "third_party/WebKit/public/platform/WebDragOperation.h"
 #include "third_party/skia/include/core/SkColor.h"
+#include "ui/base/ime/text_input_type.h"
 #include "ui/base/window_open_disposition.h"
 #include "ui/gfx/geometry/rect_f.h"
 #include "ui/gfx/native_widget_types.h"
 
 class GURL;
 
 namespace base {
 class FilePath;
 class ListValue;
 }
@@ skipping 487 matching lines @@
   virtual void ShowCertificateViewerInDevTools(
       WebContents* web_contents,
       scoped_refptr<net::X509Certificate> certificate);
 
   // Called when the active render widget is forwarding a RemoteChannel
   // compositor proto.  This is used in Blimp mode.
   virtual void ForwardCompositorProto(
       RenderWidgetHost* render_widget_host,
       const std::vector<uint8_t>& proto) {}
 
+  virtual void OnUpdateTextInputState(

[Charlie Reis, 2016/10/05 21:19:33]

All public methods here should have comments.

Also, it's a bigger problem here if this only works on Aura. 
WebContentsDelegate methods are generally expected to be platform agnostic,
unless it's clear otherwise (e.g., ifdef or clear explanation).  I'm not sure it
makes sense to only have this for one platform.

+      content::RenderWidgetHost* render_widget_host,
+      ui::TextInputType type,
+      const std::string& text,
+      const std::string& placeholder,
+      bool show_ime_if_needed) {}
+
   // Requests the app banner. This method is called from the DevTools.
   virtual void RequestAppBannerFromDevTools(content::WebContents* web_contents);
 
  protected:
   virtual ~WebContentsDelegate();
 
  private:
   friend class WebContentsImpl;
 
   // Called when |this| becomes the WebContentsDelegate for |source|.
   void Attach(WebContents* source);
 
   // Called when |this| is no longer the WebContentsDelegate for |source|.
   void Detach(WebContents* source);
 
   // The WebContents that this is currently a delegate for.
   std::set<WebContents*> attached_contents_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_