Extracting placeholder information from Webkit to Blimp

content/browser/renderer_host/render_widget_host_view_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
 
 #include <set>
 #include <utility>
 
 #include "base/auto_reset.h"
@@ skipping 2975 matching lines @@
   if (!GetInputMethod())
     return;
 
   if (did_update_state)
     GetInputMethod()->OnTextInputTypeChanged(this);
 
   const TextInputState* state = text_input_manager_->GetTextInputState();
   if (state && state->show_ime_if_needed)
     GetInputMethod()->ShowImeIfNeeded();
 
+  if (state && host_->delegate())

[nyquist, 2016/10/05 04:20:56]

Nit: I think this needs curlies. It's multi-line.

[Charlie Reis, 2016/10/05 21:19:33]

Yes, that's right.

+    host_->delegate()->OnUpdateTextInputState(host_, state->type, state->value,
+                                              state->placeholder,
+                                              state->show_ime_if_needed);

[Charlie Reis, 2016/10/05 21:19:33]

Why is this only done in Aura?

If it's not needed on other platforms, we should more clearly document that in
the delegate's declaration, so that other people don't implement it and assume
it works everywhere.

 
   if (state && state->type != ui::TEXT_INPUT_TYPE_NONE) {
     // Start monitoring the composition information if the focused node is
     // editable.
     RenderWidgetHostImpl* last_active_widget =
         text_input_manager_->GetActiveWidget();
     last_active_widget_routing_id_ = last_active_widget->GetRoutingID();
     last_active_widget_process_id_ = last_active_widget->GetProcess()->GetID();
     last_active_widget->Send(new InputMsg_RequestCompositionUpdate(
         last_active_widget->GetRoutingID(), false /* immediate request */,
@@ skipping 57 matching lines @@
           ->GetTextSelection(focused_view)
           ->GetSelectedText(&selected_text)) {
     // Set the CLIPBOARD_TYPE_SELECTION to the ui::Clipboard.
     ui::ScopedClipboardWriter clipboard_writer(ui::CLIPBOARD_TYPE_SELECTION);
     clipboard_writer.WriteText(selected_text);
   }
 #endif  // defined(USE_X11) && !defined(OS_CHROMEOS)
 }
 
 }  // namespace content