Extracting placeholder information from Webkit to Blimp

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include <map>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 57 matching lines @@
 #include "content/common/view_messages.h"
 #include "content/public/common/associated_interface_provider.h"
 #include "content/public/common/bindings_policy.h"
 #include "content/public/common/browser_side_navigation_policy.h"
 #include "content/public/common/content_constants.h"
 #include "content/public/common/content_features.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/common/context_menu_params.h"
 #include "content/public/common/file_chooser_file_info.h"
 #include "content/public/common/file_chooser_params.h"
+#include "content/public/common/form_field_data.h"
 #include "content/public/common/isolated_world_ids.h"
 #include "content/public/common/page_state.h"
 #include "content/public/common/resource_response.h"
 #include "content/public/common/service_manager_connection.h"
 #include "content/public/common/service_names.h"
 #include "content/public/common/url_constants.h"
 #include "content/public/common/url_utils.h"
 #include "content/public/renderer/browser_plugin_delegate.h"
 #include "content/public/renderer/content_renderer_client.h"
 #include "content/public/renderer/context_menu_client.h"
@@ skipping 1483 matching lines @@
     IPC_MESSAGE_HANDLER(FrameMsg_JavaScriptExecuteRequestForTests,
                         OnJavaScriptExecuteRequestForTests)
     IPC_MESSAGE_HANDLER(FrameMsg_JavaScriptExecuteRequestInIsolatedWorld,
                         OnJavaScriptExecuteRequestInIsolatedWorld)
     IPC_MESSAGE_HANDLER(FrameMsg_VisualStateRequest,
                         OnVisualStateRequest)
     IPC_MESSAGE_HANDLER(FrameMsg_Reload, OnReload)
     IPC_MESSAGE_HANDLER(FrameMsg_ReloadLoFiImages, OnReloadLoFiImages)
     IPC_MESSAGE_HANDLER(FrameMsg_TextSurroundingSelectionRequest,
                         OnTextSurroundingSelectionRequest)
+    IPC_MESSAGE_HANDLER(FrameMsg_FocusedFormFieldDataRequest,
+                        OnFocusedFormFieldDataRequest)
     IPC_MESSAGE_HANDLER(FrameMsg_SetAccessibilityMode,
                         OnSetAccessibilityMode)
     IPC_MESSAGE_HANDLER(AccessibilityMsg_SnapshotTree,
                         OnSnapshotAccessibilityTree)
     IPC_MESSAGE_HANDLER(FrameMsg_UpdateOpener, OnUpdateOpener)
     IPC_MESSAGE_HANDLER(FrameMsg_CommitNavigation, OnCommitNavigation)
     IPC_MESSAGE_HANDLER(FrameMsg_DidUpdateSandboxFlags, OnDidUpdateSandboxFlags)
     IPC_MESSAGE_HANDLER(FrameMsg_SetFrameOwnerProperties,
                         OnSetFrameOwnerProperties)
     IPC_MESSAGE_HANDLER(FrameMsg_AdvanceFocus, OnAdvanceFocus)
@@ skipping 710 matching lines @@
     return;
   }
 
   Send(new FrameHostMsg_TextSurroundingSelectionResponse(
       routing_id_,
       surroundingText.textContent(),
       surroundingText.startOffsetInTextContent(),
       surroundingText.endOffsetInTextContent()));
 }
 
+void RenderFrameImpl::OnFocusedFormFieldDataRequest(int request_id) {
+  DCHECK(frame_);
+  if (frame_ != render_view_->GetWebView()->focusedFrame())
+    return;

[David Trainor- moved to gerrit, 2016/11/11 18:44:38]

We still have to respond to the request right?

[Charlie Reis, 2016/11/11 22:20:46]

Yes, otherwise we'll have a leak in the browser for unacknowledged requests.  I
think it's worth putting a comment at the top of this method that a response is
always needed and there should be no early returns (to avoid adding this bug in
the future).

[shaktisahu, 2016/11/15 05:44:54]

Done. Sending an empty message. The blimp engine will check the message's
text_input_type field and figure out if the message succeeded.

+
+  WebElement element = frame_->document().focusedElement();
+  if (element.isNull())
+    return;

[David Trainor- moved to gerrit, 2016/11/11 18:44:38]

Same here.

[shaktisahu, 2016/11/15 05:44:54]

Done.

+
+  DCHECK(GetRenderWidget()->GetWebWidget());
+  blink::WebTextInputInfo info =
+      GetRenderWidget()->GetWebWidget()->textInputInfo();
+  FormFieldData field;
+  field.text = info.value.utf8();
+  field.placeholder = element.getAttribute("placeholder").utf8();
+  field.text_input_type = GetRenderWidget()->GetTextInputType();
+
+  Send(new FrameHostMsg_FocusedFormFieldDataResponse(routing_id_, request_id,
+                                                     field));
+}
+
 bool RenderFrameImpl::RunJavaScriptMessage(JavaScriptMessageType type,
                                            const base::string16& message,
                                            const base::string16& default_value,
                                            const GURL& frame_url,
                                            base::string16* result) {
   // Don't allow further dialogs if we are waiting to swap out, since the
   // ScopedPageLoadDeferrer in our stack prevents it.
   if (suppress_further_dialogs_)
     return false;
 
@@ skipping 4263 matching lines @@
   // event target. Potentially a Pepper plugin will receive the event.
   // In order to tell whether a plugin gets the last mouse event and which it
   // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets
   // the event, it will notify us via DidReceiveMouseEvent() and set itself as
   // |pepper_last_mouse_event_target_|.
   pepper_last_mouse_event_target_ = nullptr;
 #endif
 }
 
 }  // namespace content