Extracting placeholder information from Webkit to Blimp

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <memory>
 
@@ skipping 45 matching lines @@
 #include "content/common/render_message_filter.mojom.h"
 #include "content/common/site_isolation_policy.h"
 #include "content/common/view_messages.h"
 #include "content/public/common/bindings_policy.h"
 #include "content/public/common/browser_side_navigation_policy.h"
 #include "content/public/common/content_client.h"
 #include "content/public/common/content_constants.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/common/drop_data.h"
 #include "content/public/common/favicon_url.h"
+#include "content/public/common/form_field_data.h"
 #include "content/public/common/page_importance_signals.h"
 #include "content/public/common/page_state.h"
 #include "content/public/common/page_zoom.h"
 #include "content/public/common/three_d_api_types.h"
 #include "content/public/common/url_constants.h"
 #include "content/public/common/web_preferences.h"
 #include "content/public/renderer/content_renderer_client.h"
 #include "content/public/renderer/document_state.h"
 #include "content/public/renderer/navigation_state.h"
 #include "content/public/renderer/render_view_observer.h"
@@ skipping 1267 matching lines @@
                         OnDisableScrollbarsForSmallWindows)
     IPC_MESSAGE_HANDLER(ViewMsg_SetRendererPrefs, OnSetRendererPrefs)
     IPC_MESSAGE_HANDLER(ViewMsg_MediaPlayerActionAt, OnMediaPlayerActionAt)
     IPC_MESSAGE_HANDLER(ViewMsg_PluginActionAt, OnPluginActionAt)
     IPC_MESSAGE_HANDLER(ViewMsg_SetActive, OnSetActive)
     IPC_MESSAGE_HANDLER(ViewMsg_ShowContextMenu, OnShowContextMenu)
     IPC_MESSAGE_HANDLER(ViewMsg_ReleaseDisambiguationPopupBitmap,
                         OnReleaseDisambiguationPopupBitmap)
     IPC_MESSAGE_HANDLER(ViewMsg_ForceRedraw, OnForceRedraw)
     IPC_MESSAGE_HANDLER(ViewMsg_SelectWordAroundCaret, OnSelectWordAroundCaret)
+    IPC_MESSAGE_HANDLER(ViewMsg_GetFocusedFormFieldData,
+                        OnFocusedFormFieldDataRequested)
 
     // Page messages.
     IPC_MESSAGE_HANDLER(PageMsg_UpdateWindowScreenRect,
                         OnUpdateWindowScreenRect)
     IPC_MESSAGE_HANDLER(PageMsg_SetZoomLevel, OnSetZoomLevel)
     IPC_MESSAGE_HANDLER(PageMsg_SetDeviceScaleFactor, OnSetDeviceScaleFactor);
     IPC_MESSAGE_HANDLER(PageMsg_WasHidden, OnPageWasHidden)
     IPC_MESSAGE_HANDLER(PageMsg_WasShown, OnPageWasShown)
     IPC_MESSAGE_HANDLER(PageMsg_SetHistoryOffsetAndLength,
                         OnSetHistoryOffsetAndLength)
@@ skipping 19 matching lines @@
 
 void RenderViewImpl::OnSelectWordAroundCaret() {
   if (!webview())
     return;
 
   input_handler_->set_handling_input_event(true);
   webview()->focusedFrame()->selectWordAroundCaret();
   input_handler_->set_handling_input_event(false);
 }
 
+void RenderViewImpl::OnFocusedFormFieldDataRequested(int request_id) {
+  blink::WebFrame* web_frame = webview()->focusedFrame();

[David Trainor- moved to gerrit, 2016/11/03 04:25:49]

Should we check if webview() is null or webview()->focusedFrame() is null (some
methods do check these)?

+  WebElement element = web_frame->document().focusedElement();

[David Trainor- moved to gerrit, 2016/11/03 04:25:49]

Check if document().isNull()?  Check if focusedElement.isNull()?

+
+  blink::WebTextInputInfo info = GetWebWidget()->textInputInfo();

[David Trainor- moved to gerrit, 2016/11/03 04:25:50]

Check if GetWebWidget() is null?

+  FormFieldData field;
+  field.text = info.value.utf8();

[David Trainor- moved to gerrit, 2016/11/03 04:25:50]

Are all of these guaranteed to be valid?  info.value, element,
element.getAttribute()?  Just make sure we're checking the right thing.  Dig
into this a bit, a lot of these objects have isNull().

+  field.placeholder = element.getAttribute("placeholder").utf8();
+  field.text_input_type = GetTextInputType();
+
+  Send(
+      new ViewHostMsg_SetFocusedFormFieldData(routing_id(), request_id, field));
+}
+
 void RenderViewImpl::OnUpdateTargetURLAck() {
   // Check if there is a targeturl waiting to be sent.
   if (target_url_status_ == TARGET_PENDING)
     Send(new ViewHostMsg_UpdateTargetURL(GetRoutingID(), pending_target_url_));
 
   target_url_status_ = TARGET_NONE;
 }
 
 void RenderViewImpl::OnExecuteEditCommand(const std::string& name,
     const std::string& value) {
@@ skipping 1629 matching lines @@
   if (IsUseZoomForDSFEnabled()) {
     webview()->setZoomFactorForDeviceScaleFactor(device_scale_factor_);
   } else {
     webview()->setDeviceScaleFactor(device_scale_factor_);
   }
   webview()->settings()->setPreferCompositingToLCDTextEnabled(
       PreferCompositingToLCDText(compositor_deps_, device_scale_factor_));
 }
 
 }  // namespace content