Extracting placeholder information from Webkit to Blimp

blimp/engine/session/blimp_engine_session.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BLIMP_ENGINE_SESSION_BLIMP_ENGINE_SESSION_H_
 #define BLIMP_ENGINE_SESSION_BLIMP_ENGINE_SESSION_H_
 
 #include <stdint.h>
 
 #include <memory>
 #include <vector>
 
 #include "base/macros.h"
 #include "blimp/common/proto/blimp_message.pb.h"
 #include "blimp/engine/feature/engine_render_widget_feature.h"
 #include "blimp/engine/feature/engine_settings_feature.h"
 #include "blimp/engine/feature/geolocation/engine_geolocation_feature.h"
 #include "blimp/engine/mojo/blob_channel_service.h"
 #include "blimp/net/blimp_message_processor.h"
 #include "blimp/net/blob_channel/blob_channel_sender_impl.h"
 #include "blimp/net/connection_error_observer.h"
+#include "content/browser/renderer_host/text_input_manager.h"

[EhsanK, 2016/09/28 16:14:11]

Whether or not exposing RWHVBase and TextInputManager is OK is something creis@
(as the content/ owner) should comment on.

My question is, do we really need to observer TextInputManager?

If yes, then maybe we should have a separate content/public class which
observers TextInputManager. There are other APIs in TextInputManager which
should absolutely not called from any class other than RWHVBase (such as
UpdateTextInputState()).

I also left some comments in the cc file.

 #include "content/public/browser/invalidate_type.h"
 #include "content/public/browser/web_contents_delegate.h"
 #include "net/base/completion_callback.h"
-#include "ui/base/ime/input_method_observer.h"
 #include "ui/gfx/geometry/size.h"
 
 namespace aura {
 class WindowTreeHost;
 
 namespace client {
 class DefaultCaptureClient;
 class WindowTreeClient;
 }  // namespace client
 }  // namespace aura
@@ skipping 31 matching lines @@
 class BlimpBrowserContext;
 class BlimpEngineConfig;
 class BlimpFocusClient;
 class BlimpScreen;
 class BlimpWindowTreeHost;
 class EngineNetworkComponents;
 class Tab;
 
 class BlimpEngineSession : public BlimpMessageProcessor,
                            public content::WebContentsDelegate,
-                           public ui::InputMethodObserver {
+                           public content::TextInputManager::Observer {
  public:
   using GetPortCallback = base::Callback<void(uint16_t)>;
 
   BlimpEngineSession(std::unique_ptr<BlimpBrowserContext> browser_context,
                      net::NetLog* net_log,
                      BlimpEngineConfig* config,
                      SettingsManager* settings_manager);
   ~BlimpEngineSession() override;
 
   // Starts the network stack on the IO thread, and sets default placeholder
@@ skipping 48 matching lines @@
                           bool user_gesture,
                           bool last_unlocked_by_target) override;
   void CloseContents(content::WebContents* source) override;
   void ActivateContents(content::WebContents* contents) override;
   void ForwardCompositorProto(
       content::RenderWidgetHost* render_widget_host,
       const std::vector<uint8_t>& proto) override;
   void NavigationStateChanged(content::WebContents* source,
                               content::InvalidateTypes changed_flags) override;
 
-  // ui::InputMethodObserver overrides.
-  void OnTextInputTypeChanged(const ui::TextInputClient* client) override;
-  void OnFocus() override;
-  void OnBlur() override;
-  void OnCaretBoundsChanged(const ui::TextInputClient* client) override;
-  void OnTextInputStateChanged(const ui::TextInputClient* client) override;
-  void OnInputMethodDestroyed(const ui::InputMethod* input_method) override;
-  void OnShowImeIfNeeded() override;
+  // content::TextInputManager overrides.
+  void OnUpdateTextInputStateCalled(
+      content::TextInputManager* text_input_manager,
+      content::RenderWidgetHostViewBase* updated_view,
+      bool did_update_state) override;
 
   // Sets up |new_contents| to be associated with the root window.
   void PlatformSetContents(std::unique_ptr<content::WebContents> new_contents,
                            const int target_tab_id);
 
   // Presents the client's single screen.
   // Screen should be deleted after browser context (crbug.com/613372).
   std::unique_ptr<BlimpScreen> screen_;
 
   // Content BrowserContext for this session.
@@ skipping 57 matching lines @@
   // TODO(haibinlu): Support more than one tab (crbug/547231)
   std::unique_ptr<Tab> tab_;
 
   DISALLOW_COPY_AND_ASSIGN(BlimpEngineSession);
 };
 
 }  // namespace engine
 }  // namespace blimp
 
 #endif  // BLIMP_ENGINE_SESSION_BLIMP_ENGINE_SESSION_H_