device/generic_sensor/platform_sensor_provider_base.cc - Issue 2370343002: [sensors] Ambient light sensor implementation for ChromeOS and Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/generic_sensor/platform_sensor_provider_base.cc

Issue 2370343002: [sensors] Ambient light sensor implementation for ChromeOS and Linux. (Closed)

Patch Set: changed implementation Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/generic_sensor/platform_sensor_provider_base.cc

diff --git a/device/generic_sensor/platform_sensor_provider_base.cc b/device/generic_sensor/platform_sensor_provider_base.cc

index 6dd94dbea5ec819a89d80e849461397219163d3a..73c3fed43e10eef72ff27d1b3686c04d629f70ab 100644

--- a/device/generic_sensor/platform_sensor_provider_base.cc

+++ b/device/generic_sensor/platform_sensor_provider_base.cc

@@ -76,8 +76,8 @@ bool PlatformSensorProviderBase::CreateSharedBufferIfNeeded() {

void PlatformSensorProviderBase::RemoveSensor(mojom::SensorType type) {

DCHECK(CalledOnValidThread());

- DCHECK(ContainsKey(sensor_map_, type));

- sensor_map_.erase(type);

+ if (ContainsKey(sensor_map_, type))

Mikhail 2016/10/11 14:46:47 why this change is needed?

+ sensor_map_.erase(type);

if (sensor_map_.empty())

shared_buffer_handle_.reset();