[sensors] Ambient light sensor implementation for ChromeOS and Linux.

device/generic_sensor/sensor_provider_impl.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/generic_sensor/sensor_provider_impl.h"
 
 #include <utility>
 
 #include "device/generic_sensor/platform_sensor_provider.h"
 #include "device/generic_sensor/sensor_impl.h"
@@ skipping 14 matching lines @@
     mojom::SensorClientRequest client,
     const SensorProviderImpl::GetSensorCallback& callback) {
   base::ThreadTaskRunnerHandle::Get()->PostTask(
       FROM_HERE, base::Bind(RunCallback, base::Passed(&init_params),
                             base::Passed(&client), callback));
 }
 
 }  // namespace
 
 // static
-void SensorProviderImpl::Create(mojom::SensorProviderRequest request) {
+void SensorProviderImpl::Create(
+    scoped_refptr<base::SingleThreadTaskRunner> task_runner,
+    mojom::SensorProviderRequest request) {
   PlatformSensorProvider* provider = PlatformSensorProvider::GetInstance();
   if (provider) {
+    provider->SetTaskRunner(task_runner);

[Mikhail, 2016/10/28 11:29:03]

1) this is better to be a ctor partameter
2) it should be seen from the arg names that this is a "file" task runner

     mojo::MakeStrongBinding(base::WrapUnique(new SensorProviderImpl(provider)),
                             std::move(request));
   }
 }
 
 SensorProviderImpl::SensorProviderImpl(PlatformSensorProvider* provider)
     : provider_(provider), weak_ptr_factory_(this) {
   DCHECK(provider_);
 }
 
@@ skipping 41 matching lines @@
   init_params->mode = sensor->GetReportingMode();
   init_params->default_configuration = sensor->GetDefaultConfiguration();
 
   NotifySensorCreated(std::move(init_params), sensor_impl->GetClient(),
                       callback);
 
   mojo::MakeStrongBinding(std::move(sensor_impl), std::move(sensor_request));
 }
 
 }  // namespace device