Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6634)

Unified Diff: chrome/browser/gpu/chrome_gpu_util.cc

Issue 23703017: Enable GPU control lists in tests on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more detailed logging Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/base/test_launcher_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gpu/chrome_gpu_util.cc
diff --git a/chrome/browser/gpu/chrome_gpu_util.cc b/chrome/browser/gpu/chrome_gpu_util.cc
index 61da773e24cc355eb7b17f70808cc23d7d589970..c2f646dcdf487873d0a395714ea15f68b2ef77b2 100644
--- a/chrome/browser/gpu/chrome_gpu_util.cc
+++ b/chrome/browser/gpu/chrome_gpu_util.cc
@@ -40,32 +40,6 @@ bool ShouldRunCompositingFieldTrial() {
return false;
#endif
-// Necessary for linux_chromeos build since it defines both OS_LINUX
-// and OS_CHROMEOS.
-#if defined(OS_CHROMEOS)
- return false;
-#endif
piman 2013/09/20 21:27:35 We don't want to run GPU field trials on Chrome OS
gab 2013/09/21 03:40:09 Right, but we never make it to the field trial cod
gab 2013/09/23 21:07:52 As per offline discussion, I'll leave the OS_CHROM
-
-#if defined(OS_WIN)
- // Don't run the trial on Windows XP.
- if (base::win::GetVersion() < base::win::VERSION_VISTA)
- return false;
-#endif
-
-#if defined(OS_MACOSX)
- // Browser and content shell tests hang on 10.7 when the Apple software
- // renderer is used. These tests ignore the blacklist (which disables
- // compositing both on 10.7 and when the Apple software renderer is used)
- // by specifying the kSkipGpuDataLoading switch, so disable forced
- // compositing here based on the switch and OS version.
- // http://crbug.com/230931
- if (base::mac::IsOSLion() &&
- CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kSkipGpuDataLoading)) {
- return false;
- }
-#endif
-
// Don't activate the field trial if force-compositing-mode has been
// explicitly disabled from the command line.
if (CommandLine::ForCurrentProcess()->HasSwitch(
« no previous file with comments | « no previous file | chrome/test/base/test_launcher_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698