[blink] Use functions for AllMarkers and MisspellingMarkers

Source/core/dom/DocumentMarker.h

 /*
  * This file is part of the DOM implementation for WebCore.
  *
  * Copyright (C) 2006 Apple Computer, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 29 matching lines @@
 public:
     enum MarkerType {
         Spelling = 1 << 0,
         Grammar = 1 << 1,
         TextMatch = 1 << 2
     };
 
     class MarkerTypes {
     public:
         // The constructor is intentionally implicit to allow conversion from the bit-wise sum of above types
         MarkerTypes(unsigned mask) : m_mask(mask) { }

[tony, 2013/09/20 18:10:28]

Nit: explicit

[please use gerrit instead, 2013/09/20 18:20:29]

The comment says that "the constructor is intentionally implicit to allow
conversion from the bit-wise sum of types."

 
         bool contains(MarkerType type) const { return m_mask & type; }
         bool intersects(const MarkerTypes& types) const { return (m_mask & types.m_mask); }
         bool operator==(const MarkerTypes& other) const { return m_mask == other.m_mask; }
 
         void add(const MarkerTypes& types) { m_mask |= types.m_mask; }
         void remove(const MarkerTypes& types) { m_mask &= ~types.m_mask; }
 
     private:
         unsigned m_mask;
     };
 
-    class AllMarkers : public MarkerTypes {
-    public:
-        AllMarkers()
-            : MarkerTypes(Spelling | Grammar | TextMatch)
-        {
-        }
-    };
-
-    class MisspellingMarkers : public MarkerTypes {
-    public:
-        MisspellingMarkers()
-            : MarkerTypes(Spelling | Grammar)
-        {
-        }
-    };
+    static MarkerTypes allMarkers() { return MarkerTypes(Spelling | Grammar | TextMatch); }
+    static MarkerTypes misspellingMarkers() { return MarkerTypes(Spelling | Grammar); }
 
     DocumentMarker();
     DocumentMarker(MarkerType, unsigned startOffset, unsigned endOffset);
     DocumentMarker(MarkerType, unsigned startOffset, unsigned endOffset, const String& description);
     DocumentMarker(MarkerType, unsigned startOffset, unsigned endOffset, const String& description, uint32_t hash);
     DocumentMarker(unsigned startOffset, unsigned endOffset, bool activeMatch);
     DocumentMarker(MarkerType, unsigned startOffset, unsigned endOffset, PassRefPtr<DocumentMarkerDetails>);
 
     MarkerType type() const { return m_type; }
     unsigned startOffset() const { return m_startOffset; }
@@ skipping 41 matching lines @@
 public:
     DocumentMarkerDetails() { }
     virtual ~DocumentMarkerDetails();
     virtual bool isDescription() const { return false; }
     virtual bool isTextMatch() const { return false; }
 };
 
 } // namespace WebCore
 
 #endif // DocumentMarker_h