Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 23703014: Orthogonalize Lithium binary op instructions. (Closed)

Created:
7 years, 3 months ago by oliv
Modified:
7 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Orthogonalize Lithium binary op instructions. BUG= R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16739

Patch Set 1 : #

Total comments: 3

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -245 lines) Patch
src/arm/lithium-arm.h View 2 chunks +2 lines, -2 lines 0 comments Download
src/arm/lithium-arm.cc View 1 6 chunks +55 lines, -71 lines 0 comments Download
src/arm/lithium-codegen-arm.cc View 1 chunk +13 lines, -9 lines 0 comments Download
src/ia32/lithium-codegen-ia32.cc View 4 chunks +13 lines, -11 lines 0 comments Download
src/ia32/lithium-ia32.h View 2 chunks +2 lines, -2 lines 0 comments Download
src/ia32/lithium-ia32.cc View 8 chunks +43 lines, -75 lines 0 comments Download
src/x64/lithium-codegen-x64.cc View 1 chunk +9 lines, -5 lines 0 comments Download
src/x64/lithium-x64.h View 2 chunks +2 lines, -2 lines 0 comments Download
src/x64/lithium-x64.cc View 1 8 chunks +44 lines, -68 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
oliv
7 years, 3 months ago (2013-09-16 12:37:26 UTC) #1
Sven Panne
LGTM with nits https://codereview.chromium.org/23703014/diff/14001/src/arm/lithium-arm.cc File src/arm/lithium-arm.cc (right): https://codereview.chromium.org/23703014/diff/14001/src/arm/lithium-arm.cc#newcode759 src/arm/lithium-arm.cc:759: LOperand* left = (op == Token::MOD) ...
7 years, 3 months ago (2013-09-16 13:10:32 UTC) #2
oliv
7 years, 3 months ago (2013-09-16 15:25:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16739 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698