Orthogonalize Lithium binary op instructions.

Orthogonalize Lithium binary op instructions.

BUG=
R=svenpanne@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=16739

[Sven Panne, 2013-09-16 13:10:32]

LGTM with nits

https://codereview.chromium.org/23703014/diff/14001/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):

https://codereview.chromium.org/23703014/diff/14001/src/arm/lithium-arm.cc#ne...
src/arm/lithium-arm.cc:759: LOperand* left = (op == Token::MOD)
Refactor this into

if (op == Token::MOD) {
...
} else {
...
}

with nothing outside the "if". We basically have 2 different instructions here,
and we should be honest about it. It improves readability, and we shift towards
that style at other places, too.

https://codereview.chromium.org/23703014/diff/14001/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):

https://codereview.chromium.org/23703014/diff/14001/src/ia32/lithium-ia32.cc#...
src/ia32/lithium-ia32.cc:814: if (op == Token::MOD) return
MarkAsCall(DefineSameAsFirst(result), instr);
This is a border case: Personally I would prefer the same refactoring as for the
other platforms, even if that means some code duplication. But I'll leave this
up to you.

https://codereview.chromium.org/23703014/diff/14001/src/x64/lithium-x64.cc
File src/x64/lithium-x64.cc (right):

https://codereview.chromium.org/23703014/diff/14001/src/x64/lithium-x64.cc#ne...
src/x64/lithium-x64.cc:764: LOperand* right = (op == Token::MOD)
Same remark for MOD here...

[oliv, 2013-09-16 15:25:01]

Committed patchset #2 manually as r16739 (presubmit successful).