Issue 23703003: Couple of minor changes to the WebKitAPI. This is a small step in a larger work-in-progress. See th…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23703003: Couple of minor changes to the WebKitAPI. This is a small step in a larger work-in-progress. See th… (Closed)

Created:
7 years, 3 months ago by michaeln

Modified:
7 years, 3 months ago

Reviewers:
tkent

CC:
blink-reviews, jamesr, eae+blinkwatch, dglazkov+blink, abarth-chromium, tommyw+watchlist_chromium.org, jeez

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Couple of minor changes to the WebKitAPI. This is a small step in a larger work-in-progress. See the bug for details. * Distinguish more clearly between blobURLs and fileSystemURLs in WebBlobData and the very similar WebHTTPBody element structs. * Put in place some of the new API to identify blob data by uuid instead of blob instances by URL. What's in place enough for Blink to call out to Chromium using the new id scheme. What's not in place is enough for Chrome to call into Blink using the new scheme as Blink doesn't know how to do that yet. Blink doesn't use the new API yet but Chromium is nearly ready for it to start doing so after https://codereview.chromium.org/23223003/ lands. BUG=174200 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157024

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -27 lines)			Patch
M	Source/core/platform/chromium/support/WebHTTPBody.cpp	View		4 chunks	+11 lines, -4 lines	0 comments	Download
M	Source/web/WebBlobData.cpp	View		2 chunks	+5 lines, -3 lines	0 comments	Download
M	public/platform/WebBlobData.h	View		1 chunk	+8 lines, -3 lines	0 comments	Download
M	public/platform/WebBlobRegistry.h	View	1	1 chunk	+9 lines, -10 lines	0 comments	Download
M	public/platform/WebFileWriter.h	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	public/platform/WebHTTPBody.h	View		2 chunks	+12 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

michaeln

hi tkent, ptal, i picked you to review as git cl suggested

7 years, 3 months ago (2013-08-30 01:09:02 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaeln@chromium.org/23703003/3001

7 years, 3 months ago (2013-08-30 21:03:24 UTC) #3

Message was sent while issue was closed.

Change committed as 157024

Expand Messages | Collapse Messages