Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 2370283002: Revert of Rendering text to a canvas in a frame-less document. (Closed)

Created:
4 years, 2 months ago by zakerinasab
Modified:
4 years, 2 months ago
Reviewers:
esprehn, Justin Novosad
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Rendering text to a canvas in a frame-less document. (patchset #4 id:100001 of https://codereview.chromium.org/2336693002/ ) Reason for revert: Causes some crashes on Canary. https://bugs.chromium.org/p/chromium/issues/detail?id=650264#c1 Original issue's description: > Rendering text to a canvas in a frame-less document. > > Committed: https://crrev.com/93dd565e17f9ad8e630bfb668e5c83536af50a0f > Cr-Commit-Position: refs/heads/master@{#418400} TBR=esprehn@chromium.org,junov@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=650264, 350091 Committed: https://crrev.com/906706f4c94421c9296bc115b6c8e572cbd7d581 Cr-Commit-Position: refs/heads/master@{#421236}

Patch Set 1 #

Patch Set 2 : Manual patch revert. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -60 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/text-rendering-frameless-canvas.html View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/text-rendering-frameless-canvas-expected.html View 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontSelector.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/FontBuilder.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolverState.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 1 4 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
zakerinasab
Created Revert of Rendering text to a canvas in a frame-less document.
4 years, 2 months ago (2016-09-27 14:31:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370283002/1
4 years, 2 months ago (2016-09-27 14:31:23 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-09-27 14:31:24 UTC) #5
zakerinasab
4 years, 2 months ago (2016-09-27 14:37:04 UTC) #8
Justin Novosad
On 2016/09/27 14:37:04, zakerinasab wrote: lgtm
4 years, 2 months ago (2016-09-27 14:40:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370283002/1
4 years, 2 months ago (2016-09-27 14:40:55 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/75741) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 2 months ago (2016-09-27 14:43:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370283002/230001
4 years, 2 months ago (2016-09-27 15:35:58 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:230001)
4 years, 2 months ago (2016-09-27 16:58:44 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 17:00:30 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/906706f4c94421c9296bc115b6c8e572cbd7d581
Cr-Commit-Position: refs/heads/master@{#421236}

Powered by Google App Engine
This is Rietveld 408576698