Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1500)

Issue 23702057: Android: improvements to make jni_generator work outside of chromium (Closed)

Created:
7 years, 3 months ago by bulach
Modified:
7 years, 2 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

A few improvements to make jni_generator work outside of chromium. * Print a usage message if called with no (valid) arguments. * Determine the script name by stripping before either 'base' or 'third_party', or strip nothing if neither name can be found in the path. * Allow overriding the script name, and use this in the tests to be path-agnostic. TBR=rmcilroy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226503

Patch Set 1 #

Patch Set 2 : Update with "options" #

Total comments: 2

Patch Set 3 : Comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -42 lines) Patch
M base/android/jni_generator/golden_sample_for_tests_jni.h View 1 chunk +1 line, -1 line 0 comments Download
M base/android/jni_generator/jni_generator.py View 1 10 chunks +38 lines, -21 lines 0 comments Download
M base/android/jni_generator/jni_generator_tests.py View 1 2 16 chunks +37 lines, -20 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
bulach
7 years, 3 months ago (2013-09-24 09:20:41 UTC) #1
rmcilroy_google
lgtm
7 years, 3 months ago (2013-09-24 11:29:51 UTC) #2
rmcilroy
lgtm lgtm from my chromium account too...
7 years, 3 months ago (2013-09-24 11:31:27 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 2 months ago (2013-09-25 10:07:45 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 2 months ago (2013-09-26 08:10:41 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 2 months ago (2013-09-27 08:08:23 UTC) #6
bulach
hey ross, I updated the patch with the latest changes, would you mind another quick ...
7 years, 2 months ago (2013-09-27 12:59:36 UTC) #7
rmcilroy
On 2013/09/27 12:59:36, bulach wrote: > hey ross, I updated the patch with the latest ...
7 years, 2 months ago (2013-09-27 13:07:28 UTC) #8
rmcilroy
lgtm https://codereview.chromium.org/23702057/diff/11001/base/android/jni_generator/jni_generator_tests.py File base/android/jni_generator/jni_generator_tests.py (right): https://codereview.chromium.org/23702057/diff/11001/base/android/jni_generator/jni_generator_tests.py#newcode25 base/android/jni_generator/jni_generator_tests.py:25: class Options(object): nit - MockOptions? or maybe TestOptions?
7 years, 2 months ago (2013-09-27 13:07:56 UTC) #9
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 2 months ago (2013-09-30 09:04:33 UTC) #10
bulach
thanks! addressed, CQing with fingers crossed this time. :) https://codereview.chromium.org/23702057/diff/11001/base/android/jni_generator/jni_generator_tests.py File base/android/jni_generator/jni_generator_tests.py (right): https://codereview.chromium.org/23702057/diff/11001/base/android/jni_generator/jni_generator_tests.py#newcode25 base/android/jni_generator/jni_generator_tests.py:25: ...
7 years, 2 months ago (2013-09-30 09:04:50 UTC) #11
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 2 months ago (2013-09-30 15:10:02 UTC) #12
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 2 months ago (2013-10-01 10:08:19 UTC) #13
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 2 months ago (2013-10-02 10:53:47 UTC) #14
bulach
it has been reviewed but the "committership" flag hasn't been flipped yet, so I'm TBRing..
7 years, 2 months ago (2013-10-02 11:08:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/23702057/17001
7 years, 2 months ago (2013-10-02 11:08:33 UTC) #16
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-02 12:46:46 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/23702057/17001
7 years, 2 months ago (2013-10-02 16:32:09 UTC) #18
commit-bot: I haz the power
7 years, 2 months ago (2013-10-02 18:11:28 UTC) #19
Message was sent while issue was closed.
Change committed as 226503

Powered by Google App Engine
This is Rietveld 408576698