Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 23702048: Android: make APK targets depend on md5sum. (Closed)

Created:
7 years, 3 months ago by bulach
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Android: make APK targets depend on md5sum. The same dependency applies for all APKs, so remove from content_shell_apk and move it down to java_apk.gypi. BUG= TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224145

Patch Set 1 #

Total comments: 1

Patch Set 2 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M build/java_apk.gypi View 1 2 chunks +3 lines, -1 line 0 comments Download
M content/content_shell.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
bulach
ptal
7 years, 3 months ago (2013-09-18 13:26:00 UTC) #1
henrika (OOO until Aug 14)
LGTM but I don't know the background details well enough to give final OK.
7 years, 3 months ago (2013-09-18 13:26:58 UTC) #2
Peter Beverloo
lgtm, thanks Marcus! The change in content_shell.gypi is trivial enough to TBR. https://codereview.chromium.org/23702048/diff/1/build/java_apk.gypi File build/java_apk.gypi ...
7 years, 3 months ago (2013-09-18 13:28:42 UTC) #3
bulach
thanks! all addressed, will let cycle through the bots just to ensure there's no bizarre ...
7 years, 3 months ago (2013-09-18 14:08:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/23702048/7001
7 years, 3 months ago (2013-09-19 09:36:27 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=26327
7 years, 3 months ago (2013-09-19 09:47:07 UTC) #6
bulach
TBR=jochen@chromium.org for trivial change
7 years, 3 months ago (2013-09-19 10:11:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/23702048/7001
7 years, 3 months ago (2013-09-19 10:11:43 UTC) #8
jochen (gone - plz use gerrit)
lgtm
7 years, 3 months ago (2013-09-19 12:32:52 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-19 16:33:20 UTC) #10
Message was sent while issue was closed.
Change committed as 224145

Powered by Google App Engine
This is Rietveld 408576698