Chromium Code Reviews
Help | Chromium Project | Sign in
(50)

Issue 23702046: Added sounds for CrOS startup, lock, unlock and shutdown from go/ChromeSounds. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 7 months ago by ygorshenin1
Modified:
1 year, 7 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org, jennyz
Visibility:
Public.

Description

Added sounds for CrOS startup, lock, unlock and shutdown from go/ChromeSounds. BUG=271057 TEST=none R=jennyz@chromium.org, nkostylev@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224085

Patch Set 1 #

Patch Set 2 : Fix. #

Patch Set 3 : Fixed startup and shutdown sounds. #

Patch Set 4 : Sync. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, --4 lines) Patch
M chrome/browser/browser_resources.grd View 1 1 chunk +6 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/sounds/lock.wav View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/chromeos/sounds/shutdown.wav View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/chromeos/sounds/startup.wav View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/chromeos/sounds/unlock.wav View 1 0 chunks +-1 lines, --1 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 9 (0 generated)
ygorshenin1
1 year, 7 months ago (2013-09-18 07:09:01 UTC) #1
Nikita (OOO Apr 30-May 4)
please rename them: * drop all numbers * lower case * remove "Chrome-OS" [lock|shutdown|unlock|startup].wav
1 year, 7 months ago (2013-09-18 11:17:50 UTC) #2
ygorshenin1
PTAL
1 year, 7 months ago (2013-09-18 11:29:16 UTC) #3
Nikita (OOO Apr 30-May 4)
lgtm
1 year, 7 months ago (2013-09-18 11:51:27 UTC) #4
ygorshenin1
+ sky for chrome/browser/browser_resources.grd
1 year, 7 months ago (2013-09-18 12:30:43 UTC) #5
sky
LGTM
1 year, 7 months ago (2013-09-18 17:13:37 UTC) #6
jennyz
The bug number associated is wrong.
1 year, 7 months ago (2013-09-18 22:33:16 UTC) #7
jennyz
lgtm. Please change the bug number to the correct one.
1 year, 7 months ago (2013-09-18 22:48:04 UTC) #8
ygorshenin1
1 year, 7 months ago (2013-09-19 08:26:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 manually as r224085 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 98db9e2