Chromium Code Reviews
Help | Chromium Project | Sign in
(834)

Issue 23702046: Added sounds for CrOS startup, lock, unlock and shutdown from go/ChromeSounds. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months ago by ygorshenin1
Modified:
6 months, 4 weeks ago
Reviewers:
Nikita Kostylev, sky, jennyz
CC:
chromium-reviews_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org, jennyz
Visibility:
Public.

Description

Added sounds for CrOS startup, lock, unlock and shutdown from go/ChromeSounds.

BUG=271057
TEST=none
R=jennyz@chromium.org, nkostylev@chromium.org, sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224085

Patch Set 1 #

Patch Set 2 : Fix. #

Patch Set 3 : Fixed startup and shutdown sounds. #

Patch Set 4 : Sync. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, --4 lines) Lint Patch
M chrome/browser/browser_resources.grd View 1 1 chunk +6 lines, -0 lines 0 comments ? errors Download
A chrome/browser/resources/chromeos/sounds/lock.wav View 1 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
A chrome/browser/resources/chromeos/sounds/shutdown.wav View 1 2 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
A chrome/browser/resources/chromeos/sounds/startup.wav View 1 2 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
A chrome/browser/resources/chromeos/sounds/unlock.wav View 1 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 9
ygorshenin1
7 months ago #1
Nikita Kostylev
please rename them: * drop all numbers * lower case * remove "Chrome-OS" [lock|shutdown|unlock|startup].wav
6 months, 4 weeks ago #2
ygorshenin1
PTAL
6 months, 4 weeks ago #3
Nikita Kostylev
lgtm
6 months, 4 weeks ago #4
ygorshenin1
+ sky for chrome/browser/browser_resources.grd
6 months, 4 weeks ago #5
sky
LGTM
6 months, 4 weeks ago #6
jennyz
The bug number associated is wrong.
6 months, 4 weeks ago #7
jennyz
lgtm. Please change the bug number to the correct one.
6 months, 4 weeks ago #8
ygorshenin1
6 months, 4 weeks ago #9
Message was sent while issue was closed.
Committed patchset #4 manually as r224085 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434