runtime/bin/directory.cc - Issue 23702037: Fix error handling when current working directory is deleted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/directory.cc

Issue 23702037: Fix error handling when current working directory is deleted. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix type of _Directory._current Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/directory.cc

diff --git a/runtime/bin/directory.cc b/runtime/bin/directory.cc

index 0f771eecbdf38cde1ef019fd9b56c05e459db771..c7b499a4906c929faa64117611c0a2962fdedc96 100644

--- a/runtime/bin/directory.cc

+++ b/runtime/bin/directory.cc

@@ -26,6 +26,10 @@ void FUNCTION_NAME(Directory_Current)(Dart_NativeArguments args) {

if (current != NULL) {

Dart_SetReturnValue(args, DartUtils::NewString(current));

free(current);

+ } else {

+ Dart_Handle err = DartUtils::NewDartOSError();

+ if (Dart_IsError(err)) Dart_PropagateError(err);

+ Dart_SetReturnValue(args, err);

}

« no previous file with comments | « no previous file | runtime/bin/directory_patch.dart » ('j') | no next file with comments »