Issue 23702032: Prepare Webview's browser plugin for coming Custom Elements API change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23702032: Prepare Webview's browser plugin for coming Custom Elements API change. (Closed)

Created:
7 years, 3 months ago by dominicc (has gone to gerrit)

Modified:
7 years, 3 months ago

Reviewers:
Fady Samuel

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, lazyboy

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Prepare Webview's browser plugin for coming Custom Elements API change. The Custom Elements spec has changed to require the "extends" option for type extensions. This updates browser plugin to pass that option ahead of the Blink-side change to implement "extends". TEST=WebViewTest.* BUG=234509 R=fsamuel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222376

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/renderer/resources/extensions/web_view.js	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/23702032/1

7 years, 3 months ago (2013-09-10 06:50:29 UTC) #3

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=167271

7 years, 3 months ago (2013-09-10 08:39:37 UTC) #4

dominicc (has gone to gerrit)

7 years, 3 months ago (2013-09-10 22:46:54 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r222376 (presubmit successful).

Expand Messages | Collapse Messages