media/tools/player_x11/player_x11.cc - Issue 23702007: Render inband text tracks in the media pipeline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/tools/player_x11/player_x11.cc

Issue 23702007: Render inband text tracks in the media pipeline (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: incorporate aaron's comments (10/16) Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/tools/player_x11/player_x11.cc

diff --git a/media/tools/player_x11/player_x11.cc b/media/tools/player_x11/player_x11.cc

index c154e6937e25fba06a00b3825a2edf03ca77c696..bfd37368cab2d5ac375cc6b3899e3d8565ec466b 100644

--- a/media/tools/player_x11/player_x11.cc

+++ b/media/tools/player_x11/player_x11.cc

@@ -279,7 +279,7 @@ int main(int argc, char** argv) {

CreateDataSource(filename), command_line->HasSwitch("streaming")));

scoped_ptr<media::Demuxer> demuxer(new media::FFmpegDemuxer(

media_thread.message_loop_proxy(), data_source.get(),

- base::Bind(&NeedKey), new media::MediaLog()));

+ base::Bind(&NeedKey), true, new media::MediaLog()));

media::Pipeline pipeline(media_thread.message_loop_proxy(),

new media::MediaLog());