Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1137)

Unified Diff: media/filters/chunk_demuxer.h

Issue 23702007: Render inband text tracks in the media pipeline (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: incorporate aaron's comments (10/16) Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/chunk_demuxer.h
diff --git a/media/filters/chunk_demuxer.h b/media/filters/chunk_demuxer.h
index e7f6caed37c9c4ab0eab72d3329b35688b38f907..ab47a6d6f360c93497a7feb6cec65d93d58a4307 100644
--- a/media/filters/chunk_demuxer.h
+++ b/media/filters/chunk_demuxer.h
@@ -6,6 +6,7 @@
#define MEDIA_FILTERS_CHUNK_DEMUXER_H_
#include <map>
+#include <set>
#include <string>
#include <utility>
#include <vector>
@@ -15,7 +16,6 @@
#include "media/base/demuxer.h"
#include "media/base/ranges.h"
#include "media/base/stream_parser.h"
-#include "media/base/text_track.h"
#include "media/filters/source_buffer_stream.h"
namespace media {
@@ -38,13 +38,13 @@ class MEDIA_EXPORT ChunkDemuxer : public Demuxer {
// is ready to receive media data via AppenData().
// |need_key_cb| Run when the demuxer determines that an encryption key is
// needed to decrypt the content.
- // |add_text_track_cb| Run when demuxer detects the presence of an inband
- // text track.
+ // |enable_text| Process inband text tracks in the normal way when true,
+ // otherwise ignore them.
// |log_cb| Run when parsing error messages need to be logged to the error
// console.
ChunkDemuxer(const base::Closure& open_cb,
const NeedKeyCB& need_key_cb,
- const AddTextTrackCB& add_text_track_cb,
+ bool enable_text,
const LogCB& log_cb);
virtual ~ChunkDemuxer();
@@ -171,8 +171,10 @@ class MEDIA_EXPORT ChunkDemuxer : public Demuxer {
// has not been created before. Returns NULL otherwise.
ChunkDemuxerStream* CreateDemuxerStream(DemuxerStream::Type type);
- bool OnTextBuffers(TextTrack* text_track,
- const StreamParser::BufferQueue& buffers);
+ void OnNewTextTrack(ChunkDemuxerStream* text_stream,
+ TextKind kind,
acolwell GONE FROM CHROMIUM 2013/10/21 20:10:40 nit: Use const TextTrackConfig& here.
Matthew Heaney (Chromium) 2013/10/23 05:09:01 Done.
+ const std::string& name,
+ const std::string& language);
void OnNewMediaSegment(const std::string& source_id,
base::TimeDelta start_timestamp);
@@ -224,7 +226,7 @@ class MEDIA_EXPORT ChunkDemuxer : public Demuxer {
DemuxerHost* host_;
base::Closure open_cb_;
NeedKeyCB need_key_cb_;
- AddTextTrackCB add_text_track_cb_;
+ bool enable_text_;
// Callback used to report error strings that can help the web developer
// figure out what is wrong with the content.
LogCB log_cb_;

Powered by Google App Engine
This is Rietveld 408576698