Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: media/base/text_renderer.cc

Issue 23702007: Render inband text tracks in the media pipeline (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: incorporate aaron's comments (10/16) Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/text_renderer.cc
diff --git a/media/base/text_renderer.cc b/media/base/text_renderer.cc
new file mode 100644
index 0000000000000000000000000000000000000000..9bc37ce1a7c707666a7c8f9e1a6afe1eaab3197f
--- /dev/null
+++ b/media/base/text_renderer.cc
@@ -0,0 +1,315 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "media/base/text_renderer.h"
+
+#include "base/bind.h"
+#include "base/callback_helpers.h"
+#include "base/logging.h"
+#include "base/message_loop/message_loop_proxy.h"
+#include "base/stl_util.h"
+#include "media/base/bind_to_loop.h"
+#include "media/base/decoder_buffer.h"
+#include "media/base/demuxer.h"
+#include "media/base/demuxer_stream.h"
+#include "media/base/text_cue.h"
+
+namespace media {
+
+TextRenderer::TextRenderer(
+ const scoped_refptr<base::MessageLoopProxy>& message_loop,
+ const AddTextTrackCB& add_text_track_cb)
+ : message_loop_(message_loop),
+ weak_factory_(this),
+ add_text_track_cb_(add_text_track_cb),
+ state_(kUninitialized),
+ pending_read_count_(0),
+ pending_eos_count_(0) {
+}
+
+TextRenderer::~TextRenderer() {
+ DCHECK(state_ == kUninitialized ||
+ state_ == kStopped) << "state_ " << state_;
+ DCHECK_EQ(pending_read_count_, 0);
+
+ STLDeleteValues(&text_track_map_);
+}
+
+void TextRenderer::Initialize(const base::Closure& ended_cb) {
+ DCHECK(message_loop_->BelongsToCurrentThread());
+ DCHECK(!ended_cb.is_null());
+ DCHECK_EQ(kUninitialized, state_) << "state_ " << state_;
+ DCHECK(read_state_.empty());
+ DCHECK_EQ(pending_read_count_, 0);
+ DCHECK_EQ(pending_eos_count_, 0);
+ DCHECK(ended_cb_.is_null());
+
+ weak_this_ = weak_factory_.GetWeakPtr();
+ ended_cb_ = ended_cb;
+ state_ = kPaused;
+}
+
+void TextRenderer::Play(const base::Closure& callback) {
+ DCHECK(message_loop_->BelongsToCurrentThread());
+ DCHECK_EQ(state_, kPaused) << "state_ " << state_;
+
+ for (ReadStateMap::iterator itr = read_state_.begin();
+ itr != read_state_.end(); ++itr) {
+ if (itr->second == kReadPending) {
+ DCHECK_GT(pending_read_count_, 0);
+ continue;
+ }
+
+ itr->second = kReadPending;
+ ++pending_read_count_;
+
+ DemuxerStream* const stream = itr->first;
+ stream->Read(base::Bind(&TextRenderer::BufferReady,
+ weak_this_,
+ stream));
+ }
+
+ state_ = kPlaying;
+ callback.Run();
+}
+
+void TextRenderer::Pause(const base::Closure& callback) {
+ DCHECK(message_loop_->BelongsToCurrentThread());
+ DCHECK(state_ == kPlaying || state_ == kEnded) << "state_ " << state_;
+ DCHECK_GE(pending_read_count_, 0);
+ pause_cb_ = callback;
+
+ if (pending_read_count_ == 0) {
+ state_ = kPaused;
+ base::ResetAndReturn(&pause_cb_).Run();
+ return;
+ }
+
+ state_ = kPausePending;
+}
+
+void TextRenderer::Flush(const base::Closure& callback) {
+ DCHECK(message_loop_->BelongsToCurrentThread());
+ DCHECK_EQ(pending_read_count_, 0);
+ DCHECK(state_ == kPaused || state_ == kEnded) << "state_ " << state_;
+
+ pending_eos_count_ = read_state_.size();
+
+ callback.Run();
+}
+
+void TextRenderer::Stop(const base::Closure& cb) {
+ DCHECK(message_loop_->BelongsToCurrentThread());
+ DCHECK(!cb.is_null());
+ DCHECK(state_ == kPlaying ||
+ state_ == kPausePending ||
+ state_ == kPaused ||
+ state_ == kEnded) << "state_ " << state_;
+ DCHECK_GE(pending_read_count_, 0);
+
+ stop_cb_ = cb;
+
+ if (pending_read_count_ == 0) {
+ state_ = kStopped;
+ base::ResetAndReturn(&stop_cb_).Run();
+ return;
+ }
+
+ state_ = kStopPending;
+}
+
+void TextRenderer::AddTextStream(DemuxerStream* text_stream,
+ TextKind kind,
+ const std::string& label,
+ const std::string& language) {
+ DCHECK(message_loop_->BelongsToCurrentThread());
+ DCHECK(state_ != kUninitialized) << "state_ " << state_;
+
+ if (state_ == kStopPending || state_ == kStopped)
+ return;
+
+ media::AddTextTrackDoneCB done_cb =
+ media::BindToLoop(message_loop_,
+ base::Bind(&TextRenderer::OnAddTextTrackDone,
+ weak_this_,
+ text_stream));
+
+ add_text_track_cb_.Run(kind, label, language, done_cb);
+}
+
+void TextRenderer::RemoveTextStream(DemuxerStream* text_stream) {
+ DCHECK(message_loop_->BelongsToCurrentThread());
+
+ ReadStateMap::iterator read_state_it = read_state_.find(text_stream);
+
+ if (read_state_it != read_state_.end()) {
+ DCHECK_EQ(read_state_it->second, kReadIdle);
+ read_state_.erase(read_state_it);
+ }
+
+ TextTrackMap::iterator text_track_it = text_track_map_.find(text_stream);
+
+ if (text_track_it != text_track_map_.end()) {
+ media::TextTrack* text_track = text_track_it->second;
+ text_track_map_.erase(text_track_it);
+ delete text_track;
+ }
+}
+
+bool TextRenderer::HasTracks() const {
+ DCHECK(message_loop_->BelongsToCurrentThread());
+ return !text_track_map_.empty();
+}
+
+void TextRenderer::BufferReady(
+ DemuxerStream* stream,
+ DemuxerStream::Status status,
+ const scoped_refptr<DecoderBuffer>& input) {
+ DCHECK(message_loop_->BelongsToCurrentThread());
+ DCHECK_NE(status, DemuxerStream::kConfigChanged);
+
+ if (status == DemuxerStream::kAborted) {
+ DCHECK(!input.get());
acolwell GONE FROM CHROMIUM 2013/10/21 20:10:40 nit: Do you really need the .get() here?
Matthew Heaney (Chromium) 2013/10/23 05:09:01 Done.
+ DCHECK_GT(pending_read_count_, 0);
+ DCHECK_GT(pending_eos_count_, 0);
+ DCHECK_EQ(read_state_[stream], kReadPending);
+
+ --pending_read_count_;
+ --pending_eos_count_;
acolwell GONE FROM CHROMIUM 2013/10/21 20:10:40 Why is the eos count being decremented here? An ab
Matthew Heaney (Chromium) 2013/10/23 05:09:01 Done.
+ read_state_[stream] = kReadIdle;
+ return;
+ }
+
+ if (input->end_of_stream()) {
+ CueReady(stream, NULL);
+ return;
+ }
+
+ DCHECK_EQ(status, DemuxerStream::kOk);
+ DCHECK_GE(input->side_data_size(), 2);
+
+ // The side data contains both the cue id and cue settings,
+ // each terminated with a NUL.
+ const char* id_ptr = reinterpret_cast<const char*>(input->side_data());
+ size_t id_len = strlen(id_ptr);
+ std::string id(id_ptr, id_len);
+
+ const char* settings_ptr = id_ptr + id_len + 1;
+ size_t settings_len = strlen(settings_ptr);
+ std::string settings(settings_ptr, settings_len);
+
+ // The cue payload is stored in the data-part of the input buffer.
+ std::string text(input->data(), input->data() + input->data_size());
+
+ scoped_refptr<TextCue> text_cue(
+ new TextCue(input->timestamp(),
+ input->duration(),
+ id,
+ settings,
+ text));
+
+ CueReady(stream, text_cue);
+}
+
+void TextRenderer::CueReady(
+ DemuxerStream* text_stream,
+ const scoped_refptr<TextCue>& text_cue) {
+ DCHECK(message_loop_->BelongsToCurrentThread());
+ DCHECK(state_ != kUninitialized &&
+ state_ != kStopped) << "state_ " << state_;
+ DCHECK_GT(pending_read_count_, 0);
+ DCHECK_GT(pending_eos_count_, 0);
+ DCHECK_EQ(read_state_[text_stream], kReadPending);
+
+ --pending_read_count_;
+ read_state_[text_stream] = kReadIdle;
+
+ switch (state_) {
+ case kPlaying:
+ case kPausePending:
+ if (text_cue)
+ break;
+
+ // A NULL buffer means that we have reached EOS (or there's an error).
+
+ --pending_eos_count_;
+
+ if (pending_eos_count_ > 0)
+ return;
+
+ if (state_ == kPausePending)
+ pause_cb_.Run();
+
+ state_ = kEnded;
+ ended_cb_.Run();
+
+ return;
+
+ case kStopPending:
+ if (pending_read_count_ == 0) {
+ state_ = kStopped;
+ stop_cb_.Run();
+ }
+
+ return;
+
+ case kPaused:
+ case kStopped:
+ case kUninitialized:
acolwell GONE FROM CHROMIUM 2013/10/21 20:10:40 Missing kEnded from this switch
Matthew Heaney (Chromium) 2013/10/23 05:09:01 Done.
+ NOTREACHED();
+ return;
+ }
+
+ TextTrackMap::iterator it = text_track_map_.find(text_stream);
+ DCHECK(it != text_track_map_.end());
+
+ media::TextTrack* text_track = it->second;
+ DCHECK(text_track);
+
+ base::TimeDelta start = text_cue->timestamp();
+ base::TimeDelta end = start + text_cue->duration();
+
+ text_track->addWebVTTCue(start, end,
+ text_cue->id(),
acolwell GONE FROM CHROMIUM 2013/10/21 20:10:40 nit: Fix indent
Matthew Heaney (Chromium) 2013/10/23 05:09:01 Done.
+ text_cue->text(),
+ text_cue->settings());
+
+ if (state_ == kPlaying) {
+ read_state_[text_stream] = kReadPending;
+ ++pending_read_count_;
+ text_stream->Read(base::Bind(&TextRenderer::BufferReady,
+ weak_this_,
+ text_stream));
+ return;
+ }
+
+ if (pending_read_count_ == 0) {
+ state_ = kPaused;
acolwell GONE FROM CHROMIUM 2013/10/21 20:10:40 DCHECK_EQ(state_, kPausePending) << " state_ << "
Matthew Heaney (Chromium) 2013/10/23 05:09:01 Done.
+ pause_cb_.Run();
+ }
+}
+
+void TextRenderer::OnAddTextTrackDone(DemuxerStream* text_stream,
+ scoped_ptr<TextTrack> text_track) {
+ DCHECK(message_loop_->BelongsToCurrentThread());
+ DCHECK(state_ != kUninitialized &&
+ state_ != kStopped) << "state_ " << state_;
+
+ text_track_map_[text_stream] = text_track.release();
+
+ ++pending_eos_count_;
+
+ if (state_ != kPlaying) {
+ read_state_[text_stream] = kReadIdle;
+ } else {
+ read_state_[text_stream] = kReadPending;
+ ++pending_read_count_;
+
+ text_stream->Read(base::Bind(&TextRenderer::BufferReady,
+ weak_this_,
+ text_stream));
+ }
+}
+
+} // namespace media

Powered by Google App Engine
This is Rietveld 408576698