Chromium Code Reviews| Index: media/base/stream_parser.h |
| diff --git a/media/base/stream_parser.h b/media/base/stream_parser.h |
| index 33a336def8bc4e418750fc5f472856469b54dece..a27a05c2c87e2426ddf347647747cd40a7bf86d7 100644 |
| --- a/media/base/stream_parser.h |
| +++ b/media/base/stream_parser.h |
| @@ -43,11 +43,14 @@ class MEDIA_EXPORT StreamParser { |
| // then it means that there isn't an audio stream. |
| // Second parameter - The new video configuration. If the config is not valid |
| // then it means that there isn't an audio stream. |
| + // Third parameter - The new text tracks configuration. If the map is empty, |
| + // then no text tracks were parsed from the stream. |
| // Return value - True if the new configurations are accepted. |
| // False if the new configurations are not supported |
| // and indicates that a parsing error should be signalled. |
| typedef base::Callback<bool(const AudioDecoderConfig&, |
| - const VideoDecoderConfig&)> NewConfigCB; |
| + const VideoDecoderConfig&, |
| + const TextTrackConfigMap&)> NewConfigCB; |
| // New stream buffers have been parsed. |
| // First parameter - A queue of newly parsed audio buffers. |
| @@ -59,12 +62,14 @@ class MEDIA_EXPORT StreamParser { |
| const BufferQueue&)> NewBuffersCB; |
| // New stream buffers of inband text have been parsed. |
| - // First parameter - The text track to which these cues will be added. |
| + // First parameter - The (number of the) text track to which these cues will |
|
acolwell GONE FROM CHROMIUM
2013/10/21 20:10:40
nit: s/number/id & drop the parenthesis.
Matthew Heaney (Chromium)
2013/10/23 05:09:01
Done.
|
| + // be added. |
| // Second parameter - A queue of newly parsed buffers. |
| // Return value - True indicates that the buffers are accepted. |
| // False if something was wrong with the buffers and a parsing |
| // error should be signalled. |
| - typedef base::Callback<bool(TextTrack*, const BufferQueue&)> NewTextBuffersCB; |
| + typedef base::Callback<bool(int track_number, |
|
acolwell GONE FROM CHROMIUM
2013/10/21 20:10:40
nit: remove name here
Matthew Heaney (Chromium)
2013/10/23 05:09:01
Done.
|
| + const BufferQueue&)> NewTextBuffersCB; |
| // Signals the beginning of a new media segment. |
| typedef base::Callback<void()> NewMediaSegmentCB; |
| @@ -85,7 +90,7 @@ class MEDIA_EXPORT StreamParser { |
| const NewBuffersCB& new_buffers_cb, |
| const NewTextBuffersCB& text_cb, |
| const NeedKeyCB& need_key_cb, |
| - const AddTextTrackCB& add_text_track_cb, |
| + bool enable_text_tracks, |
| const NewMediaSegmentCB& new_segment_cb, |
| const base::Closure& end_of_segment_cb, |
| const LogCB& log_cb) = 0; |