Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Unified Diff: content/renderer/media/webmediaplayer_impl.h

Issue 23702007: Render inband text tracks in the media pipeline (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: incorporate aaron's comments (10/16) Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webmediaplayer_impl.h
diff --git a/content/renderer/media/webmediaplayer_impl.h b/content/renderer/media/webmediaplayer_impl.h
index 5de76c17643879add91b6fa92c0c1cfd6a7dcc36..e014c93430310465ef91101a0bd1cdc2dc935f6e 100644
--- a/content/renderer/media/webmediaplayer_impl.h
+++ b/content/renderer/media/webmediaplayer_impl.h
@@ -55,7 +55,6 @@ class MessageLoopProxy;
namespace media {
class ChunkDemuxer;
-class FFmpegDemuxer;
class GpuVideoAcceleratorFactories;
class MediaLog;
}
@@ -196,9 +195,11 @@ class WebMediaPlayerImpl
const std::string& default_url);
void OnNeedKey(const std::string& type,
const std::vector<uint8>& init_data);
- scoped_ptr<media::TextTrack> OnTextTrack(media::TextKind kind,
- const std::string& label,
- const std::string& language);
+ void OnAddTextTrack(media::TextKind kind,
+ const std::string& label,
+ const std::string& language,
acolwell GONE FROM CHROMIUM 2013/10/21 20:10:40 nit: Use const TextTrackConfig& here instead of th
Matthew Heaney (Chromium) 2013/10/23 05:09:01 Done.
+ const media::AddTextTrackDoneCB& done_cb);
+
void SetOpaque(bool);
private:

Powered by Google App Engine
This is Rietveld 408576698