Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: content/renderer/media/texttrack_impl.h

Issue 23702007: Render inband text tracks in the media pipeline (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: incorporate aaron's comments (10/16) Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/media/texttrack_impl.cc » ('j') | content/renderer/media/texttrack_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/texttrack_impl.h
diff --git a/content/renderer/media/texttrack_impl.h b/content/renderer/media/texttrack_impl.h
index 09007c6b17af8a33526f30e2b27a837e216bf46c..961d15600ea65448df384a42d8f51cc21b83b023 100644
--- a/content/renderer/media/texttrack_impl.h
+++ b/content/renderer/media/texttrack_impl.h
@@ -11,7 +11,12 @@
#include "base/memory/scoped_ptr.h"
#include "media/base/text_track.h"
+namespace base {
+class MessageLoopProxy;
+}
+
namespace WebKit {
+class WebInbandTextTrackClient;
class WebMediaPlayerClient;
}
@@ -22,7 +27,8 @@ class WebInbandTextTrackImpl;
class TextTrackImpl : public media::TextTrack {
public:
// Constructor assumes ownership of the |text_track| object.
- TextTrackImpl(WebKit::WebMediaPlayerClient* client,
+ TextTrackImpl(const scoped_refptr<base::MessageLoopProxy>& message_loop,
+ WebKit::WebMediaPlayerClient* client,
WebInbandTextTrackImpl* text_track);
virtual ~TextTrackImpl();
@@ -34,6 +40,17 @@ class TextTrackImpl : public media::TextTrack {
const std::string& settings) OVERRIDE;
private:
+ static void OnAddCue(WebInbandTextTrackImpl* text_track,
+ const base::TimeDelta& start,
+ const base::TimeDelta& end,
+ const std::string& id,
+ const std::string& content,
+ const std::string& settings);
+
+ static void OnRemoveTrack(WebKit::WebMediaPlayerClient* client,
+ WebInbandTextTrackImpl* text_track);
acolwell GONE FROM CHROMIUM 2013/10/21 20:10:40 nit: Use scoped_ptr for text_track.
Matthew Heaney (Chromium) 2013/10/23 05:09:01 Done.
+
+ scoped_refptr<base::MessageLoopProxy> message_loop_;
WebKit::WebMediaPlayerClient* client_;
scoped_ptr<WebInbandTextTrackImpl> text_track_;
DISALLOW_COPY_AND_ASSIGN(TextTrackImpl);
« no previous file with comments | « no previous file | content/renderer/media/texttrack_impl.cc » ('j') | content/renderer/media/texttrack_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698