media/filters/pipeline_integration_test.cc - Issue 23702007: Render inband text tracks in the media pipeline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/pipeline_integration_test.cc

Issue 23702007: Render inband text tracks in the media pipeline (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: incorporate aaron's comments (9/28) Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/pipeline_integration_test.cc

diff --git a/media/filters/pipeline_integration_test.cc b/media/filters/pipeline_integration_test.cc

index 92d8fc7ee0a9dbb5c642c101023be8617a70146b..86fcb7fffeb141a0f08c6969e095d5bc5e627f4d 100644

--- a/media/filters/pipeline_integration_test.cc

+++ b/media/filters/pipeline_integration_test.cc

@@ -1072,7 +1072,8 @@ TEST_F(PipelineIntegrationTest, BasicPlayback_VP8A_WebM) {

}

// Verify that VP8 video with inband text track can be played back.

-TEST_F(PipelineIntegrationTest, BasicPlayback_VP8_WebVTT_WebM) {

+TEST_F(PipelineIntegrationTest,

+ DISABLED_BasicPlayback_VP8_WebVTT_WebM) {

acolwell GONE FROM CHROMIUM 2013/10/08 15:45:24 nit: enable test

Matthew Heaney (Chromium) 2013/10/13 05:30:17 Done.

ASSERT_TRUE(Start(GetTestDataFilePath("bear-vp8-webvtt.webm"),

PIPELINE_OK));

Play();