Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: media/filters/chunk_demuxer.h

Issue 23702007: Render inband text tracks in the media pipeline (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: fix compile errors 11/21 #6 Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/text_track_config.cc ('k') | media/filters/chunk_demuxer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/chunk_demuxer.h
diff --git a/media/filters/chunk_demuxer.h b/media/filters/chunk_demuxer.h
index cb2b72ca2b3ed566256128180b152e0da606fb9f..51739dbeecad1af2403ea35fe877983821307858 100644
--- a/media/filters/chunk_demuxer.h
+++ b/media/filters/chunk_demuxer.h
@@ -15,7 +15,6 @@
#include "media/base/demuxer.h"
#include "media/base/ranges.h"
#include "media/base/stream_parser.h"
-#include "media/base/text_track.h"
#include "media/filters/source_buffer_stream.h"
namespace media {
@@ -38,19 +37,19 @@ class MEDIA_EXPORT ChunkDemuxer : public Demuxer {
// is ready to receive media data via AppenData().
// |need_key_cb| Run when the demuxer determines that an encryption key is
// needed to decrypt the content.
- // |add_text_track_cb| Run when demuxer detects the presence of an inband
- // text track.
+ // |enable_text| Process inband text tracks in the normal way when true,
+ // otherwise ignore them.
// |log_cb| Run when parsing error messages need to be logged to the error
// console.
ChunkDemuxer(const base::Closure& open_cb,
const NeedKeyCB& need_key_cb,
- const AddTextTrackCB& add_text_track_cb,
const LogCB& log_cb);
virtual ~ChunkDemuxer();
// Demuxer implementation.
virtual void Initialize(DemuxerHost* host,
- const PipelineStatusCB& cb) OVERRIDE;
+ const PipelineStatusCB& cb,
+ bool enable_text_tracks) OVERRIDE;
virtual void Stop(const base::Closure& callback) OVERRIDE;
virtual void Seek(base::TimeDelta time, const PipelineStatusCB& cb) OVERRIDE;
virtual void OnAudioRendererDisabled() OVERRIDE;
@@ -177,8 +176,8 @@ class MEDIA_EXPORT ChunkDemuxer : public Demuxer {
// has not been created before. Returns NULL otherwise.
ChunkDemuxerStream* CreateDemuxerStream(DemuxerStream::Type type);
- bool OnTextBuffers(TextTrack* text_track,
- const StreamParser::BufferQueue& buffers);
+ void OnNewTextTrack(ChunkDemuxerStream* text_stream,
+ const TextTrackConfig& config);
void OnNewMediaSegment(const std::string& source_id,
base::TimeDelta start_timestamp);
@@ -230,7 +229,7 @@ class MEDIA_EXPORT ChunkDemuxer : public Demuxer {
DemuxerHost* host_;
base::Closure open_cb_;
NeedKeyCB need_key_cb_;
- AddTextTrackCB add_text_track_cb_;
+ bool enable_text_;
// Callback used to report error strings that can help the web developer
// figure out what is wrong with the content.
LogCB log_cb_;
« no previous file with comments | « media/base/text_track_config.cc ('k') | media/filters/chunk_demuxer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698