Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1741)

Unified Diff: content/renderer/media/android/media_source_delegate.cc

Issue 23702007: Render inband text tracks in the media pipeline (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: fix compile errors 11/21 #6 Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/android/media_source_delegate.h ('k') | content/renderer/media/texttrack_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/android/media_source_delegate.cc
diff --git a/content/renderer/media/android/media_source_delegate.cc b/content/renderer/media/android/media_source_delegate.cc
index 7d7e917e4fbb0d0b7f78ae2626b464709eab8758..57fc0157ca4ed157ea1e4837d90ee9153ae90d5e 100644
--- a/content/renderer/media/android/media_source_delegate.cc
+++ b/content/renderer/media/android/media_source_delegate.cc
@@ -40,13 +40,6 @@ const uint8 kVorbisPadding[] = { 0xff, 0xff, 0xff, 0xff };
namespace content {
-static scoped_ptr<media::TextTrack> ReturnNullTextTrack(
- media::TextKind kind,
- const std::string& label,
- const std::string& language) {
- return scoped_ptr<media::TextTrack>();
-}
-
static void LogMediaSourceError(const scoped_refptr<media::MediaLog>& media_log,
const std::string& error) {
media_log->AddEvent(media_log->CreateMediaSourceErrorEvent(error));
@@ -164,7 +157,6 @@ void MediaSourceDelegate::InitializeMediaSource(
&MediaSourceDelegate::OnDemuxerOpened, main_weak_this_)),
media::BindToCurrentLoop(base::Bind(
&MediaSourceDelegate::OnNeedKey, main_weak_this_)),
- base::Bind(&ReturnNullTextTrack),
base::Bind(&LogMediaSourceError, media_log_)));
demuxer_ = chunk_demuxer_.get();
@@ -179,7 +171,8 @@ void MediaSourceDelegate::InitializeDemuxer() {
DCHECK(media_loop_->BelongsToCurrentThread());
demuxer_client_->AddDelegate(demuxer_client_id_, this);
demuxer_->Initialize(this, base::Bind(&MediaSourceDelegate::OnDemuxerInitDone,
- media_weak_factory_.GetWeakPtr()));
+ media_weak_factory_.GetWeakPtr()),
+ false);
}
#if defined(GOOGLE_TV)
@@ -506,6 +499,19 @@ void MediaSourceDelegate::OnDemuxerError(media::PipelineStatus status) {
update_network_state_cb_.Run(PipelineErrorToNetworkState(status));
}
+void MediaSourceDelegate::AddTextStream(
+ media::DemuxerStream* /* text_stream */ ,
+ const media::TextTrackConfig& /* config */ ) {
+ // TODO(matthewjheaney): add text stream (http://crbug/322115).
+ NOTIMPLEMENTED();
+}
+
+void MediaSourceDelegate::RemoveTextStream(
+ media::DemuxerStream* /* text_stream */ ) {
+ // TODO(matthewjheaney): remove text stream (http://crbug/322115).
+ NOTIMPLEMENTED();
+}
+
void MediaSourceDelegate::OnDemuxerInitDone(media::PipelineStatus status) {
DCHECK(media_loop_->BelongsToCurrentThread());
DVLOG(1) << __FUNCTION__ << "(" << status << ") : " << demuxer_client_id_;
« no previous file with comments | « content/renderer/media/android/media_source_delegate.h ('k') | content/renderer/media/texttrack_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698