Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "media/base/pipeline.h" | 5 #include "media/base/pipeline.h" |
| 6 | 6 |
| 7 #include <algorithm> | 7 #include <algorithm> |
| 8 | 8 |
| 9 #include "base/bind.h" | 9 #include "base/bind.h" |
| 10 #include "base/callback.h" | 10 #include "base/callback.h" |
| 11 #include "base/callback_helpers.h" | 11 #include "base/callback_helpers.h" |
| 12 #include "base/compiler_specific.h" | 12 #include "base/compiler_specific.h" |
| 13 #include "base/message_loop/message_loop.h" | 13 #include "base/message_loop/message_loop.h" |
| 14 #include "base/metrics/histogram.h" | 14 #include "base/metrics/histogram.h" |
| 15 #include "base/stl_util.h" | 15 #include "base/stl_util.h" |
| 16 #include "base/strings/string_number_conversions.h" | 16 #include "base/strings/string_number_conversions.h" |
| 17 #include "base/strings/string_util.h" | 17 #include "base/strings/string_util.h" |
| 18 #include "base/synchronization/condition_variable.h" | 18 #include "base/synchronization/condition_variable.h" |
| 19 #include "media/base/audio_decoder.h" | 19 #include "media/base/audio_decoder.h" |
| 20 #include "media/base/audio_renderer.h" | 20 #include "media/base/audio_renderer.h" |
| 21 #include "media/base/clock.h" | 21 #include "media/base/clock.h" |
| 22 #include "media/base/filter_collection.h" | 22 #include "media/base/filter_collection.h" |
| 23 #include "media/base/media_log.h" | 23 #include "media/base/media_log.h" |
| 24 #include "media/base/text_decoder.h" | |
|
acolwell GONE FROM CHROMIUM
2013/09/25 23:23:10
nit: It doesn't look like this is needed anywhere.
Matthew Heaney (Chromium)
2013/09/29 03:31:23
Done.
| |
| 25 #include "media/base/text_renderer.h" | |
| 24 #include "media/base/video_decoder.h" | 26 #include "media/base/video_decoder.h" |
| 25 #include "media/base/video_decoder_config.h" | 27 #include "media/base/video_decoder_config.h" |
| 26 #include "media/base/video_renderer.h" | 28 #include "media/base/video_renderer.h" |
| 27 | 29 |
| 28 using base::TimeDelta; | 30 using base::TimeDelta; |
| 29 | 31 |
| 30 namespace media { | 32 namespace media { |
| 31 | 33 |
| 32 Pipeline::Pipeline(const scoped_refptr<base::MessageLoopProxy>& message_loop, | 34 Pipeline::Pipeline(const scoped_refptr<base::MessageLoopProxy>& message_loop, |
| 33 MediaLog* media_log) | 35 MediaLog* media_log) |
| 34 : message_loop_(message_loop), | 36 : message_loop_(message_loop), |
| 35 media_log_(media_log), | 37 media_log_(media_log), |
| 36 running_(false), | 38 running_(false), |
| 37 did_loading_progress_(false), | 39 did_loading_progress_(false), |
| 38 total_bytes_(0), | 40 total_bytes_(0), |
| 39 natural_size_(0, 0), | 41 natural_size_(0, 0), |
| 40 volume_(1.0f), | 42 volume_(1.0f), |
| 41 playback_rate_(0.0f), | 43 playback_rate_(0.0f), |
| 42 clock_(new Clock(&default_tick_clock_)), | 44 clock_(new Clock(&default_tick_clock_)), |
| 43 waiting_for_clock_update_(false), | 45 waiting_for_clock_update_(false), |
| 44 status_(PIPELINE_OK), | 46 status_(PIPELINE_OK), |
| 45 has_audio_(false), | 47 has_audio_(false), |
| 46 has_video_(false), | 48 has_video_(false), |
| 47 state_(kCreated), | 49 state_(kCreated), |
| 48 audio_ended_(false), | 50 audio_ended_(false), |
| 49 video_ended_(false), | 51 video_ended_(false), |
| 52 text_ended_(false), | |
| 50 audio_disabled_(false), | 53 audio_disabled_(false), |
| 51 demuxer_(NULL), | 54 demuxer_(NULL), |
| 52 creation_time_(default_tick_clock_.NowTicks()) { | 55 creation_time_(default_tick_clock_.NowTicks()) { |
| 53 media_log_->AddEvent(media_log_->CreatePipelineStateChangedEvent(kCreated)); | 56 media_log_->AddEvent(media_log_->CreatePipelineStateChangedEvent(kCreated)); |
| 54 media_log_->AddEvent( | 57 media_log_->AddEvent( |
| 55 media_log_->CreateEvent(MediaLogEvent::PIPELINE_CREATED)); | 58 media_log_->CreateEvent(MediaLogEvent::PIPELINE_CREATED)); |
| 56 } | 59 } |
| 57 | 60 |
| 58 Pipeline::~Pipeline() { | 61 Pipeline::~Pipeline() { |
| 59 DCHECK(thread_checker_.CalledOnValidThread()) | 62 DCHECK(thread_checker_.CalledOnValidThread()) |
| (...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 286 break; | 289 break; |
| 287 } | 290 } |
| 288 NOTREACHED() << "State has no transition: " << state_; | 291 NOTREACHED() << "State has no transition: " << state_; |
| 289 return state_; | 292 return state_; |
| 290 } | 293 } |
| 291 | 294 |
| 292 void Pipeline::OnDemuxerError(PipelineStatus error) { | 295 void Pipeline::OnDemuxerError(PipelineStatus error) { |
| 293 SetError(error); | 296 SetError(error); |
| 294 } | 297 } |
| 295 | 298 |
| 299 void Pipeline::AddTextStream(DemuxerStream* text_stream, | |
| 300 TextKind kind, | |
| 301 const std::string& label, | |
| 302 const std::string& language) { | |
| 303 DCHECK(message_loop_->BelongsToCurrentThread()); | |
| 304 text_renderer_->AddTextStream(text_stream, kind, label, language); | |
| 305 } | |
| 306 | |
| 296 void Pipeline::SetError(PipelineStatus error) { | 307 void Pipeline::SetError(PipelineStatus error) { |
| 297 DCHECK(IsRunning()); | 308 DCHECK(IsRunning()); |
| 298 DCHECK_NE(PIPELINE_OK, error); | 309 DCHECK_NE(PIPELINE_OK, error); |
| 299 VLOG(1) << "Media pipeline error: " << error; | 310 VLOG(1) << "Media pipeline error: " << error; |
| 300 | 311 |
| 301 message_loop_->PostTask(FROM_HERE, base::Bind( | 312 message_loop_->PostTask(FROM_HERE, base::Bind( |
| 302 &Pipeline::ErrorChangedTask, base::Unretained(this), error)); | 313 &Pipeline::ErrorChangedTask, base::Unretained(this), error)); |
| 303 | 314 |
| 304 media_log_->AddEvent(media_log_->CreatePipelineErrorEvent(error)); | 315 media_log_->AddEvent(media_log_->CreatePipelineErrorEvent(error)); |
| 305 } | 316 } |
| (...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 530 | 541 |
| 531 // Pause. | 542 // Pause. |
| 532 if (audio_renderer_) { | 543 if (audio_renderer_) { |
| 533 bound_fns.Push(base::Bind( | 544 bound_fns.Push(base::Bind( |
| 534 &AudioRenderer::Pause, base::Unretained(audio_renderer_.get()))); | 545 &AudioRenderer::Pause, base::Unretained(audio_renderer_.get()))); |
| 535 } | 546 } |
| 536 if (video_renderer_) { | 547 if (video_renderer_) { |
| 537 bound_fns.Push(base::Bind( | 548 bound_fns.Push(base::Bind( |
| 538 &VideoRenderer::Pause, base::Unretained(video_renderer_.get()))); | 549 &VideoRenderer::Pause, base::Unretained(video_renderer_.get()))); |
| 539 } | 550 } |
| 551 if (text_renderer_) { | |
| 552 bound_fns.Push(base::Bind( | |
| 553 &TextRenderer::Pause, base::Unretained(text_renderer_.get()))); | |
| 554 } | |
| 540 | 555 |
| 541 // Flush. | 556 // Flush. |
| 542 if (audio_renderer_) { | 557 if (audio_renderer_) { |
| 543 bound_fns.Push(base::Bind( | 558 bound_fns.Push(base::Bind( |
| 544 &AudioRenderer::Flush, base::Unretained(audio_renderer_.get()))); | 559 &AudioRenderer::Flush, base::Unretained(audio_renderer_.get()))); |
| 545 } | 560 } |
| 546 if (video_renderer_) { | 561 if (video_renderer_) { |
| 547 bound_fns.Push(base::Bind( | 562 bound_fns.Push(base::Bind( |
| 548 &VideoRenderer::Flush, base::Unretained(video_renderer_.get()))); | 563 &VideoRenderer::Flush, base::Unretained(video_renderer_.get()))); |
| 549 } | 564 } |
| 565 if (text_renderer_) { | |
| 566 bound_fns.Push(base::Bind( | |
| 567 &TextRenderer::Flush, base::Unretained(text_renderer_.get()))); | |
| 568 } | |
| 550 | 569 |
| 551 // Seek demuxer. | 570 // Seek demuxer. |
| 552 bound_fns.Push(base::Bind( | 571 bound_fns.Push(base::Bind( |
| 553 &Demuxer::Seek, base::Unretained(demuxer_), seek_timestamp)); | 572 &Demuxer::Seek, base::Unretained(demuxer_), seek_timestamp)); |
| 554 | 573 |
| 555 // Preroll renderers. | 574 // Preroll renderers. |
| 556 if (audio_renderer_) { | 575 if (audio_renderer_) { |
| 557 bound_fns.Push(base::Bind( | 576 bound_fns.Push(base::Bind( |
| 558 &AudioRenderer::Preroll, base::Unretained(audio_renderer_.get()), | 577 &AudioRenderer::Preroll, base::Unretained(audio_renderer_.get()), |
| 559 seek_timestamp)); | 578 seek_timestamp)); |
| (...skipping 19 matching lines...) Expand all Loading... | |
| 579 if (audio_renderer_) { | 598 if (audio_renderer_) { |
| 580 bound_fns.Push(base::Bind( | 599 bound_fns.Push(base::Bind( |
| 581 &AudioRenderer::Play, base::Unretained(audio_renderer_.get()))); | 600 &AudioRenderer::Play, base::Unretained(audio_renderer_.get()))); |
| 582 } | 601 } |
| 583 | 602 |
| 584 if (video_renderer_) { | 603 if (video_renderer_) { |
| 585 bound_fns.Push(base::Bind( | 604 bound_fns.Push(base::Bind( |
| 586 &VideoRenderer::Play, base::Unretained(video_renderer_.get()))); | 605 &VideoRenderer::Play, base::Unretained(video_renderer_.get()))); |
| 587 } | 606 } |
| 588 | 607 |
| 608 if (text_renderer_) { | |
| 609 bound_fns.Push(base::Bind( | |
| 610 &TextRenderer::Play, base::Unretained(text_renderer_.get()))); | |
| 611 } | |
| 612 | |
| 589 pending_callbacks_ = SerialRunner::Run(bound_fns, done_cb); | 613 pending_callbacks_ = SerialRunner::Run(bound_fns, done_cb); |
| 590 } | 614 } |
| 591 | 615 |
| 592 void Pipeline::DoStop(const PipelineStatusCB& done_cb) { | 616 void Pipeline::DoStop(const PipelineStatusCB& done_cb) { |
| 593 DCHECK(message_loop_->BelongsToCurrentThread()); | 617 DCHECK(message_loop_->BelongsToCurrentThread()); |
| 594 DCHECK(!pending_callbacks_.get()); | 618 DCHECK(!pending_callbacks_.get()); |
| 595 SerialRunner::Queue bound_fns; | 619 SerialRunner::Queue bound_fns; |
| 596 | 620 |
| 597 if (demuxer_) { | 621 if (demuxer_) { |
| 598 bound_fns.Push(base::Bind( | 622 bound_fns.Push(base::Bind( |
| 599 &Demuxer::Stop, base::Unretained(demuxer_))); | 623 &Demuxer::Stop, base::Unretained(demuxer_))); |
| 600 } | 624 } |
| 601 | 625 |
| 602 if (audio_renderer_) { | 626 if (audio_renderer_) { |
| 603 bound_fns.Push(base::Bind( | 627 bound_fns.Push(base::Bind( |
| 604 &AudioRenderer::Stop, base::Unretained(audio_renderer_.get()))); | 628 &AudioRenderer::Stop, base::Unretained(audio_renderer_.get()))); |
| 605 } | 629 } |
| 606 | 630 |
| 607 if (video_renderer_) { | 631 if (video_renderer_) { |
| 608 bound_fns.Push(base::Bind( | 632 bound_fns.Push(base::Bind( |
| 609 &VideoRenderer::Stop, base::Unretained(video_renderer_.get()))); | 633 &VideoRenderer::Stop, base::Unretained(video_renderer_.get()))); |
| 610 } | 634 } |
| 611 | 635 |
| 636 if (text_renderer_) { | |
| 637 bound_fns.Push(base::Bind( | |
| 638 &TextRenderer::Stop, base::Unretained(text_renderer_.get()))); | |
| 639 } | |
| 640 | |
| 612 pending_callbacks_ = SerialRunner::Run(bound_fns, done_cb); | 641 pending_callbacks_ = SerialRunner::Run(bound_fns, done_cb); |
| 613 } | 642 } |
| 614 | 643 |
| 615 void Pipeline::OnStopCompleted(PipelineStatus status) { | 644 void Pipeline::OnStopCompleted(PipelineStatus status) { |
| 616 DCHECK(message_loop_->BelongsToCurrentThread()); | 645 DCHECK(message_loop_->BelongsToCurrentThread()); |
| 617 DCHECK_EQ(state_, kStopping); | 646 DCHECK_EQ(state_, kStopping); |
| 618 { | 647 { |
| 619 base::AutoLock l(lock_); | 648 base::AutoLock l(lock_); |
| 620 running_ = false; | 649 running_ = false; |
| 621 } | 650 } |
| 622 | 651 |
| 623 SetState(kStopped); | 652 SetState(kStopped); |
| 624 pending_callbacks_.reset(); | 653 pending_callbacks_.reset(); |
| 625 filter_collection_.reset(); | 654 filter_collection_.reset(); |
| 626 audio_renderer_.reset(); | 655 audio_renderer_.reset(); |
| 627 video_renderer_.reset(); | 656 video_renderer_.reset(); |
| 657 text_renderer_.reset(); | |
| 628 demuxer_ = NULL; | 658 demuxer_ = NULL; |
| 629 | 659 |
| 630 // If we stop during initialization/seeking we want to run |seek_cb_| | 660 // If we stop during initialization/seeking we want to run |seek_cb_| |
| 631 // followed by |stop_cb_| so we don't leave outstanding callbacks around. | 661 // followed by |stop_cb_| so we don't leave outstanding callbacks around. |
| 632 if (!seek_cb_.is_null()) { | 662 if (!seek_cb_.is_null()) { |
| 633 base::ResetAndReturn(&seek_cb_).Run(status_); | 663 base::ResetAndReturn(&seek_cb_).Run(status_); |
| 634 error_cb_.Reset(); | 664 error_cb_.Reset(); |
| 635 } | 665 } |
| 636 if (!stop_cb_.is_null()) { | 666 if (!stop_cb_.is_null()) { |
| 637 error_cb_.Reset(); | 667 error_cb_.Reset(); |
| (...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 678 media_log_->AddEvent(media_log_->CreateEvent(MediaLogEvent::AUDIO_ENDED)); | 708 media_log_->AddEvent(media_log_->CreateEvent(MediaLogEvent::AUDIO_ENDED)); |
| 679 } | 709 } |
| 680 | 710 |
| 681 void Pipeline::OnVideoRendererEnded() { | 711 void Pipeline::OnVideoRendererEnded() { |
| 682 // Force post to process ended messages after current execution frame. | 712 // Force post to process ended messages after current execution frame. |
| 683 message_loop_->PostTask(FROM_HERE, base::Bind( | 713 message_loop_->PostTask(FROM_HERE, base::Bind( |
| 684 &Pipeline::DoVideoRendererEnded, base::Unretained(this))); | 714 &Pipeline::DoVideoRendererEnded, base::Unretained(this))); |
| 685 media_log_->AddEvent(media_log_->CreateEvent(MediaLogEvent::VIDEO_ENDED)); | 715 media_log_->AddEvent(media_log_->CreateEvent(MediaLogEvent::VIDEO_ENDED)); |
| 686 } | 716 } |
| 687 | 717 |
| 718 void Pipeline::OnTextRendererEnded() { | |
| 719 // Force post to process ended messages after current execution frame. | |
| 720 message_loop_->PostTask(FROM_HERE, base::Bind( | |
| 721 &Pipeline::DoTextRendererEnded, base::Unretained(this))); | |
| 722 media_log_->AddEvent(media_log_->CreateEvent(MediaLogEvent::TEXT_ENDED)); | |
| 723 } | |
| 724 | |
| 688 // Called from any thread. | 725 // Called from any thread. |
| 689 void Pipeline::OnUpdateStatistics(const PipelineStatistics& stats) { | 726 void Pipeline::OnUpdateStatistics(const PipelineStatistics& stats) { |
| 690 base::AutoLock auto_lock(lock_); | 727 base::AutoLock auto_lock(lock_); |
| 691 statistics_.audio_bytes_decoded += stats.audio_bytes_decoded; | 728 statistics_.audio_bytes_decoded += stats.audio_bytes_decoded; |
| 692 statistics_.video_bytes_decoded += stats.video_bytes_decoded; | 729 statistics_.video_bytes_decoded += stats.video_bytes_decoded; |
| 693 statistics_.video_frames_decoded += stats.video_frames_decoded; | 730 statistics_.video_frames_decoded += stats.video_frames_decoded; |
| 694 statistics_.video_frames_dropped += stats.video_frames_dropped; | 731 statistics_.video_frames_dropped += stats.video_frames_dropped; |
| 695 } | 732 } |
| 696 | 733 |
| 697 void Pipeline::StartTask(scoped_ptr<FilterCollection> filter_collection, | 734 void Pipeline::StartTask(scoped_ptr<FilterCollection> filter_collection, |
| 698 const base::Closure& ended_cb, | 735 const base::Closure& ended_cb, |
| 699 const PipelineStatusCB& error_cb, | 736 const PipelineStatusCB& error_cb, |
| 700 const PipelineStatusCB& seek_cb, | 737 const PipelineStatusCB& seek_cb, |
| 701 const BufferingStateCB& buffering_state_cb, | 738 const BufferingStateCB& buffering_state_cb, |
| 702 const base::Closure& duration_change_cb) { | 739 const base::Closure& duration_change_cb) { |
| 703 DCHECK(message_loop_->BelongsToCurrentThread()); | 740 DCHECK(message_loop_->BelongsToCurrentThread()); |
| 704 CHECK_EQ(kCreated, state_) | 741 CHECK_EQ(kCreated, state_) |
| 705 << "Media pipeline cannot be started more than once"; | 742 << "Media pipeline cannot be started more than once"; |
| 706 | 743 |
| 707 filter_collection_ = filter_collection.Pass(); | 744 filter_collection_ = filter_collection.Pass(); |
| 708 ended_cb_ = ended_cb; | 745 ended_cb_ = ended_cb; |
| 709 error_cb_ = error_cb; | 746 error_cb_ = error_cb; |
| 710 seek_cb_ = seek_cb; | 747 seek_cb_ = seek_cb; |
| 711 buffering_state_cb_ = buffering_state_cb; | 748 buffering_state_cb_ = buffering_state_cb; |
| 712 duration_change_cb_ = duration_change_cb; | 749 duration_change_cb_ = duration_change_cb; |
| 713 | 750 |
| 751 text_renderer_ = filter_collection_->GetTextRenderer(); | |
| 752 | |
| 753 if (text_renderer_) | |
| 754 text_renderer_->Initialize( | |
| 755 base::Bind(&Pipeline::OnTextRendererEnded, base::Unretained(this))); | |
| 756 | |
| 714 StateTransitionTask(PIPELINE_OK); | 757 StateTransitionTask(PIPELINE_OK); |
| 715 } | 758 } |
| 716 | 759 |
| 717 void Pipeline::StopTask(const base::Closure& stop_cb) { | 760 void Pipeline::StopTask(const base::Closure& stop_cb) { |
| 718 DCHECK(message_loop_->BelongsToCurrentThread()); | 761 DCHECK(message_loop_->BelongsToCurrentThread()); |
| 719 DCHECK(stop_cb_.is_null()); | 762 DCHECK(stop_cb_.is_null()); |
| 720 | 763 |
| 721 if (state_ == kStopped) { | 764 if (state_ == kStopped) { |
| 722 stop_cb.Run(); | 765 stop_cb.Run(); |
| 723 return; | 766 return; |
| (...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 795 return; | 838 return; |
| 796 } | 839 } |
| 797 | 840 |
| 798 DCHECK(seek_cb_.is_null()); | 841 DCHECK(seek_cb_.is_null()); |
| 799 | 842 |
| 800 SetState(kSeeking); | 843 SetState(kSeeking); |
| 801 base::TimeDelta seek_timestamp = std::max(time, demuxer_->GetStartTime()); | 844 base::TimeDelta seek_timestamp = std::max(time, demuxer_->GetStartTime()); |
| 802 seek_cb_ = seek_cb; | 845 seek_cb_ = seek_cb; |
| 803 audio_ended_ = false; | 846 audio_ended_ = false; |
| 804 video_ended_ = false; | 847 video_ended_ = false; |
| 848 text_ended_ = false; | |
| 805 | 849 |
| 806 // Kick off seeking! | 850 // Kick off seeking! |
| 807 { | 851 { |
| 808 base::AutoLock auto_lock(lock_); | 852 base::AutoLock auto_lock(lock_); |
| 809 if (clock_->IsPlaying()) | 853 if (clock_->IsPlaying()) |
| 810 clock_->Pause(); | 854 clock_->Pause(); |
| 811 clock_->SetTime(seek_timestamp, seek_timestamp); | 855 clock_->SetTime(seek_timestamp, seek_timestamp); |
| 812 } | 856 } |
| 813 DoSeek(seek_timestamp, base::Bind( | 857 DoSeek(seek_timestamp, base::Bind( |
| 814 &Pipeline::OnStateTransition, base::Unretained(this))); | 858 &Pipeline::OnStateTransition, base::Unretained(this))); |
| (...skipping 23 matching lines...) Expand all Loading... | |
| 838 | 882 |
| 839 if (state_ != kStarted) | 883 if (state_ != kStarted) |
| 840 return; | 884 return; |
| 841 | 885 |
| 842 DCHECK(!video_ended_); | 886 DCHECK(!video_ended_); |
| 843 video_ended_ = true; | 887 video_ended_ = true; |
| 844 | 888 |
| 845 RunEndedCallbackIfNeeded(); | 889 RunEndedCallbackIfNeeded(); |
| 846 } | 890 } |
| 847 | 891 |
| 892 void Pipeline::DoTextRendererEnded() { | |
| 893 DCHECK(message_loop_->BelongsToCurrentThread()); | |
| 894 | |
| 895 if (state_ != kStarted) | |
| 896 return; | |
| 897 | |
| 898 DCHECK(!text_ended_); | |
| 899 text_ended_ = true; | |
| 900 | |
| 901 RunEndedCallbackIfNeeded(); | |
| 902 } | |
| 903 | |
| 848 void Pipeline::RunEndedCallbackIfNeeded() { | 904 void Pipeline::RunEndedCallbackIfNeeded() { |
| 849 DCHECK(message_loop_->BelongsToCurrentThread()); | 905 DCHECK(message_loop_->BelongsToCurrentThread()); |
| 850 | 906 |
| 851 if (audio_renderer_ && !audio_ended_ && !audio_disabled_) | 907 if (audio_renderer_ && !audio_ended_ && !audio_disabled_) |
| 852 return; | 908 return; |
| 853 | 909 |
| 854 if (video_renderer_ && !video_ended_) | 910 if (video_renderer_ && !video_ended_) |
| 855 return; | 911 return; |
| 856 | 912 |
| 913 if (text_renderer_ && !text_ended_) | |
|
acolwell GONE FROM CHROMIUM
2013/09/25 23:23:10
I think you may need to add a HasTracks() method o
Matthew Heaney (Chromium)
2013/09/29 03:31:23
Done.
| |
| 914 return; | |
| 915 | |
| 857 { | 916 { |
| 858 base::AutoLock auto_lock(lock_); | 917 base::AutoLock auto_lock(lock_); |
| 859 clock_->EndOfStream(); | 918 clock_->EndOfStream(); |
| 860 } | 919 } |
| 861 | 920 |
| 862 DCHECK_EQ(status_, PIPELINE_OK); | 921 DCHECK_EQ(status_, PIPELINE_OK); |
| 863 ended_cb_.Run(); | 922 ended_cb_.Run(); |
| 864 } | 923 } |
| 865 | 924 |
| 866 void Pipeline::AudioDisabledTask() { | 925 void Pipeline::AudioDisabledTask() { |
| (...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 942 void Pipeline::StartClockIfWaitingForTimeUpdate_Locked() { | 1001 void Pipeline::StartClockIfWaitingForTimeUpdate_Locked() { |
| 943 lock_.AssertAcquired(); | 1002 lock_.AssertAcquired(); |
| 944 if (!waiting_for_clock_update_) | 1003 if (!waiting_for_clock_update_) |
| 945 return; | 1004 return; |
| 946 | 1005 |
| 947 waiting_for_clock_update_ = false; | 1006 waiting_for_clock_update_ = false; |
| 948 clock_->Play(); | 1007 clock_->Play(); |
| 949 } | 1008 } |
| 950 | 1009 |
| 951 } // namespace media | 1010 } // namespace media |
| OLD | NEW |