Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 23702006: rebaseline.py self-test: validate that unknown fields are maintained (Closed)

Created:
7 years, 3 months ago by epoger
Modified:
7 years, 3 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

rebaseline.py self-test: validate that unknown fields are maintained BUG=skia:1569 R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=11008

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M tools/tests/rebaseline/input/json1/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/tests/rebaseline/output/using-json1-expectations/output-expected/gm-expectations/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
epoger
This might be a good opportunity to discuss self-test do's and don'ts, as per https://code.google.com/p/skia/issues/detail?id=1568 ...
7 years, 3 months ago (2013-08-28 17:42:55 UTC) #1
epoger
Ping... On 2013/08/28 17:42:55, epoger wrote: > This might be a good opportunity to discuss ...
7 years, 3 months ago (2013-08-29 16:33:01 UTC) #2
bsalomon
On 2013/08/29 16:33:01, epoger wrote: > Ping... > > On 2013/08/28 17:42:55, epoger wrote: > ...
7 years, 3 months ago (2013-08-29 17:49:59 UTC) #3
epoger
7 years, 3 months ago (2013-08-29 18:04:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r11008 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698